create github action workflow for linting html

[Roshanjossey]

address: #142

[jancborchardt]

I am probably not too knowledgeable about this so excuse the possibly silly question @Roshanjossey :) – should the lint not run through properly on this pull request then? As it seems it failed.

[sleepypioneer]

I am probably not too knowledgeable about this so excuse the possibly silly question @Roshanjossey :) – should the lint not run through properly on this pull request then? As it seems it failed.

The failing one is the old circle CI linter. The new one doesn't appear to have run here.

[Roshanjossey]

I tried this in my fork before raising a PR here. Roshanjossey#3

Lint action runs there and fails with expected error messages.

My theory about it not running here is that there is higher security restriction here to prevent workflows in PRs running

[sleepypioneer]

I see the following

I selected option 3 : allow opensourcediversity ....

[sleepypioneer]

probably we need some change, maybe close and reopen this PR? reading here I think that would do it

[sleepypioneer]

hmm still not running 🤔 maybe we can change it to on push? I would have to read up more on which of those options that we can choose from for actions should be selected perhaps it needs to be less restictive

[sleepypioneer]

any reason to not use v3?

[Roshanjossey]

No, updated to v3

[sleepypioneer]

I changed the settings for including github created actions (somehow thought this would have been default 🤪 )

[sleepypioneer]

ok sorry @Roshanjossey I got there now 😅 The setting I chose did not include github created actions, I noticed here the following:

--

Error: .github#L1
actions/checkout@v2 is not allowed to be used in opensourcediversity/opensourcediversity.org. Actions in this workflow must be: within a repository owned by opensourcediversity.

[sleepypioneer]

now it runs but fails because of the following reasons:

line 195 column 119 - Warning: unescaped & or unknown entity "&I"
line 196 column 53 - Warning: unescaped & or unknown entity "&I"
line 34 column 33 - Warning: trimming empty
line 35 column 68 - Warning: trimming empty
line 357 column 41 - Warning: proprietary attribute "dnt"

as it's not very many do you want to fix them here?

[Roshanjossey]

Thank you for following up @sleepypioneer. Ended up fixing #152 too when fixing lint errors

[sleepypioneer]

is this a new thing? Seems like a good thing but I am not very familiar with this code. Not sure if this was related to a failing HTML linter or if seemed appropriate to add this in here?

[Roshanjossey]

This is a re-implementation of hamburger button for menu in mobile width that got removed in #138

This has to be handled to pass lint because the empty button and span tags trigger warnings from tidy.

I decided not to revert to old changes and implement it in a different way because this would be a more semantic HTML way to do this.

Also, interestingly, this bug may have been introduced to fix lint errors (as described in #123). So, we're coming full circle.

[sleepypioneer]

thanks for clarifying 🙏 I could certainly do with a refresh of the code base!

[sleepypioneer]

thank you for taking this on @Roshanjossey, awesome improvement

[jancborchardt]

Thanks a bunch, also for all the fixes! :) Let's get this in