Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #45

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Activating Open Collective #45

merged 3 commits into from
Nov 19, 2018

Conversation

monkeywithacupcake
Copy link
Contributor

@monkeywithacupcake monkeywithacupcake commented Aug 30, 2018

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/opensourcediversity ❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

@jancborchardt jancborchardt added the improvement Improves on something that already exists label Sep 1, 2018
## Contributors

This project exists thanks to all the people who contribute.
<a href="graphs/contributors"><img src="https://opencollective.com/opensourcediversity/contributors.svg?width=890&button=false" /></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this image is not found? Otherwise it looks good! :)

@jancborchardt
Copy link
Member

@monkeywithacupcake awesome, thank you so much for adding the elements! :) It only seems that the one image I commented on is not found – what’s wrong there?

Check it out too @evalica @sleepypioneer @Incabell @jonatoni :)

@monkeywithacupcake
Copy link
Contributor Author

This is weird behavior but has been happening for some Open Collectives. I'll post on the SLACK board.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is found now! Thanks a lot @monkeywithacupcake! :)

@jancborchardt
Copy link
Member

Please review too @jonatoni @camilasan @evalica and others :)

<a href="https://opencollective.com/opensourcediversity/sponsor/6/website" target="_blank"><img src="https://opencollective.com/opensourcediversity/sponsor/6/avatar.svg"></a>
<a href="https://opencollective.com/opensourcediversity/sponsor/7/website" target="_blank"><img src="https://opencollective.com/opensourcediversity/sponsor/7/avatar.svg"></a>
<a href="https://opencollective.com/opensourcediversity/sponsor/8/website" target="_blank"><img src="https://opencollective.com/opensourcediversity/sponsor/8/avatar.svg"></a>
<a href="https://opencollective.com/opensourcediversity/sponsor/9/website" target="_blank"><img src="https://opencollective.com/opensourcediversity/sponsor/9/avatar.svg"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know what these links and images are supposed to do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am asking since there is an asymmetry between the way the Contributors and Backers have been added (with a single img) compared to 9 link + img.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the preview/diff to see how it looks like :) – it shows the avatars of the sponsors https://github.com/opensourcediversity/opensourcediversity.org/pull/45/files?short_path=04c6e90#diff-04c6e90faac2675aa89e2176d2eec7d8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the assymetry exists, might just be that it’s a work in progress.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the preview, but I don't see any avatar. Maybe because we don't have sponsors. Do you see anything there? :)

@evalica
Copy link
Member

evalica commented Nov 19, 2018

The PR looks great. I'm loving how the Contributors are shown. My comment now is will all the emotions and the rainbow feel all over :) too much colors. But that's Jan's fault :) Thanks @monkeywithacupcake for your contribution!

@jancborchardt jancborchardt merged commit 34e8fd4 into opensourcediversity:master Nov 19, 2018
@jancborchardt
Copy link
Member

Adjusted it a bit so we don’t have so many headings, looks great! Thank you so much @monkeywithacupcake! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves on something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants