Make attributes implementation compatible with only_full_group_by #2538

klisle · 2019-09-12T22:06:33Z

Background information

IMPORTANT: If you choose to ignore this issue report template, your issue will be closed as we cannot help without the requested information.

Please make sure you tick (add an x between the square brackets with no spaces) the following check boxes:

Reporting an issue of an unmodified OSPOS installation
[] Checked open and closed issues and no similar issue was already reported (please make sure you searched!)
Read README, WHATS_NEW, INSTALL.md and UPGRADE
Read the FAQ for any known install and/or upgrade gotchas (in specific PHP extensions installed)
Read the wiki
Executed any database upgrade scripts if an upgrade pre 3.0.0 (e.g. database/2.4_to_3.0.sql)
Aware the installation code is in bintray (see README), and GitHub master is for developers only and therefore not complete nor stable

Installation information

OSPOS version is: 3.3.0 - 8c1735
.Browser: Chrome
.Server Software: Apache/2.4.29 (Ubuntu)
.PHP Version: 7.2.19-0ubuntu0.18.04.2
.DB Version: 5.7.27-0ubuntu0.18.04.1
.OS: Linux ip-172-31-95-97 4.15.0-1047-aws Item -> List of Item Data Location Sort is not working in Ospos 2.3.2 #49-Ubuntu SMP Fri Aug 23 09:02:45 UTC 2019 x86_64

Issue / Bug / Question / New Feature

Having this issue with the latest bin tray. I have tried with multiple 3.3.0 builds from bintray. I have also tried from a fresh install with a new database. I have deployed 3.2.0 and 3.2.3 before and had no issues. What am I missing please?

SteveIreland · 2019-09-12T23:52:10Z

You should be okay with the version of PHP, MySQL, and Apache. I'm using about the same versions and it works fine.

Can you go to Office >> Configuration >> System Information and provide a screen print of what you see there? It might let you know if there is a feature that isn't properly installed

klisle · 2019-09-13T05:41:39Z

@SteveIreland Hey, here'e the copy of system info. Thanks.

OSPOS Installation Info: 3.3.0 - 8c1735
Language Code: en-US

Extensions & Modules:
» GD: Enabled ✓
» BC Math: Enabled ✓
» INTL: Enabled ✓
» OpenSSL: Enabled ✓
» MBString: Enabled ✓
» Curl: Enabled ✓

User Settings:
.Browser: Chrome
.Server Software: Apache/2.4.29 (Ubuntu)
.PHP Version: 7.2.19-0ubuntu0.18.04.2
.DB Version: 5.7.27-0ubuntu0.18.04.1
.Server Port: 80
.OS: Linux ip-172-31-95-97 4.15.0-1048-aws #50-Ubuntu SMP Wed Sep 4 22:03:52 UTC 2019 x86_64

File Permissions:
» [application/logs:] - 0777 | Writable ✓
» [public/uploads:] - 0777 | Writable ✓
» [public/uploads/item_pics:] - 0777 | Writable ✓
» [import_customers.csv:] - 0777 | Writable ✓

odiea · 2019-09-13T13:10:00Z

Works fine in Windows using Wamp server.

SteveIreland · 2019-09-13T13:17:57Z

We'll just need to wait for @mckaygerhard to enlighten us since he knows what is causing the problem experienced by @klisle

odiea · 2019-09-13T13:24:12Z

I found this on the internet so permissions look ok to me.

Symbolic Notation	Numeric Notation	English
----------	0000	no permissions
-rwx------	0700	read, write, & execute only for owner
-rwxrwx---	0770	read, write, & execute for owner and group
-rwxrwxrwx	0777	read, write, & execute for owner, group and others
---x--x--x	0111	execute
--w--w--w-	0222	write
--wx-wx-wx	0333	write & execute
-r--r--r--	0444	read
-r-xr-xr-x	0555	read & execute
-rw-rw-rw-	0666	read & write
-rwxr-----	0740	owner can read, write, & execute; group can only read; others have no permissions

klisle · 2019-09-13T16:26:01Z

@mckaygerhard @odiea @SteveIreland I changed the permissions to 777 just for the purpose of testing what could possibly be wrong with the installation :) I know it shouldn't be for production though. I have tried also using a newly created database. The only part that is not working for me is the "New Item". creating new supplier or new customer etc all work fine.

odiea · 2019-09-13T16:47:23Z

@klisle The version number you are using appears to be 2 months old. Here is the most current unstable version. Please try it and see if anything changes for you.
https://bintray.com/jekkos/opensourcepos/download_file?file_path=opensourcepos.20190911204733.master.427432.zip

klisle · 2019-09-13T16:51:40Z

@klisle The version number you are using appears to be 2 months old. Here is the most current unstable version. Please try it and see if anything changes for you.
https://bintray.com/jekkos/opensourcepos/download_file?file_path=opensourcepos.20190911204733.master.427432.zip

I will try but as I said I tried with multiple, probably including that one, this was just the one I decided to take the screenshot from. I always try everything I can before asking for help. It is weird though.

klisle · 2019-09-13T17:34:10Z

@odiea @SteveIreland the most recent one, opensourcepos.20190911204733.master.427432.zip, has the same issue. I just extracted the zip and replaced my html folder with it. Please see the attachments for the login, new item and system info snips As I said, add supplier, add customer etc. work fine but new item does not. Thanks a lot guys.

odiea · 2019-09-13T17:40:18Z

Have you created any attributes? If so see if removing them from Items changes anything

daN4cat · 2019-09-13T17:42:47Z

If you do key F12 in Google Chrome before opening the dialog box, when you create the error do you see some errors in the debug console?

klisle · 2019-09-13T17:58:43Z

Have you created any attributes? If so see if removing them from Items changes anything

I haven't created anything except a user

If you do key F12 in Google Chrome before opening the dialog box, when you create the error do you see some errors in the debug console?

@SteveIreland @daN4cat Indeed! items/view. please see below!

odiea · 2019-09-13T18:46:10Z

My only suggestion would be to see if you have in application/views/items/form.php and check to see what permissions it has. It appears to not be there to me.

daN4cat · 2019-09-13T18:52:17Z

@klisle please click that link with 3.85..../view and a new window should open. Take a snapshot of that please.

klisle · 2019-09-13T19:06:52Z

@klisle please click that link with 3.85..../view and a new window should open. Take a snapshot of that please.

@daN4cat http 500 error. I even changed the ownership to www-data and permissions to 777 but the issue persists

daN4cat · 2019-09-13T19:55:06Z

Are you exposing the web server directly or behind some reverse proxy or similar?

klisle · 2019-09-13T20:27:01Z

Are you exposing the web server directly or behind some reverse proxy or similar?

no reverse proxy. running on aws ec2

klisle · 2019-09-16T19:41:29Z

I have tried again with a new ubuntu ec2 host, LAMP, and the issue persists, new item pop-up is blank/empty. I tested the 3.2.3 release and new item worked fine but stops working once I am using 3.3.0. As I said before the issue only occurs with new item in 3.3.0; new supplier, new customer, new employee work fine. It doesn't appear to be an htaccess issue since only new item doesn't work in 3.3.0 AND since all aspects of 3.2.3 work fine.

daN4cat · 2019-09-16T21:49:52Z

@klisle any way you can share an access credential to your installation to see what's wrong? I need to read what's behind that 500 Error.

klisle · 2019-09-16T23:14:34Z

@klisle any way you can share an access credential to your installation to see what's wrong? I need to read what's behind that 500 Error.

Hey @daN4cat provide me with a public key and I can make it happen.

@mckaygerhard I tested with lighttpd but had no success with the new item, its still the only thing not working :(
You said "define index.php" but I am not sure what you mean, there is already an index.php file defined in the public folder.

klisle · 2019-09-20T15:57:24Z

ok I have copied

…

On Fri, Sep 20, 2019 at 2:54 AM FrancescoUK ***@***.***> wrote: Once you have copied I'll delete the post. If you send me the URL and credentials I will have a look into that over the week end. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2538?email_source=notifications&email_token=ANARCKCCUSCQPRBXBY4PEJ3QKR6RTA5CNFSM4IWKDSZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7F42MQ#issuecomment-533450034>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANARCKFOKRMYB2EBVS2PDLDQKR6RTANCNFSM4IWKDSZA> .

daN4cat · 2019-09-20T19:04:56Z

Good

klisle · 2019-09-23T17:34:51Z

@daN4cat can you generate an ssh key-pair instead? I did some reading around utilizing PGP key for ssh auth and it would require a number of changes that I would have to make and test. It would be a lot easier for you to generate a new rsa keypair and provide me with the public key to add to my ec2 instance.

daN4cat · 2019-09-23T17:47:24Z

@klisle I need url and login credentials to your ospos to see the issue and check what error is returned. I don't plan to ssh to your ec2 instance.

daN4cat · 2019-09-23T17:47:57Z

I thought you wanted to encrypted that info.

daN4cat · 2020-01-03T10:44:19Z

@odiea any chance to test this with MySQL since you were able to reproduce? Thanks in advance.

odiea · 2020-01-03T11:25:17Z

Did not help out here. Same error opening Item Kits or trying to open Item Modal to add or update.

ERROR - 2020-01-03 04:21:33 --> Query error: In aggregated query without GROUP BY, expression #28 of SELECT list contains nonaggregated column 'ospos3.ospos_suppliers.company_name'; this is incompatible with sql_mode=only_full_group_by - Invalid query: SELECT `ospos_items`.*, GROUP_CONCAT(attribute_value SEPARATOR '|') AS attribute_values, GROUP_CONCAT(attribute_decimal SEPARATOR '|') AS attribute_dvalues, GROUP_CONCAT(attribute_date SEPARATOR '|') AS attribute_dtvalues, `ospos_suppliers`.`company_name`
FROM `ospos_items`
LEFT JOIN `ospos_suppliers` ON `ospos_suppliers`.`person_id` = `ospos_items`.`supplier_id`
LEFT JOIN `ospos_attribute_links` ON `ospos_attribute_links`.`item_id` = `ospos_items`.`item_id`
LEFT JOIN `ospos_attribute_values` ON `ospos_attribute_links`.`attribute_id` = `ospos_attribute_values`.`attribute_id`
WHERE `ospos_items`.`item_id` = '1'
ERROR - 2020-01-03 04:21:57 --> Query error: In aggregated query without GROUP BY, expression #28 of SELECT list contains nonaggregated column 'ospos3.ospos_suppliers.company_name'; this is incompatible with sql_mode=only_full_group_by - Invalid query: SELECT `ospos_items`.*, GROUP_CONCAT(attribute_value SEPARATOR '|') AS attribute_values, GROUP_CONCAT(attribute_decimal SEPARATOR '|') AS attribute_dvalues, GROUP_CONCAT(attribute_date SEPARATOR '|') AS attribute_dtvalues, `ospos_suppliers`.`company_name`
FROM `ospos_items`
LEFT JOIN `ospos_suppliers` ON `ospos_suppliers`.`person_id` = `ospos_items`.`supplier_id`
LEFT JOIN `ospos_attribute_links` ON `ospos_attribute_links`.`item_id` = `ospos_items`.`item_id`
LEFT JOIN `ospos_attribute_values` ON `ospos_attribute_links`.`attribute_id` = `ospos_attribute_values`.`attribute_id`
WHERE `ospos_items`.`item_id` = '1'

daN4cat · 2020-01-03T11:32:22Z

@jekkos more to fix I'm afraid....

jekkos · 2020-01-03T11:46:37Z

But item overview does load?

odiea · 2020-01-03T11:52:19Z

Item tables load ok.
Item_kits tables does not load.
Item add or update does not load.
Item_kits add or update appears to load properly.

jekkos · 2020-01-03T11:53:06Z

Ok did another fix, will replace mariadb with mysql locally and will test myself.

jekkos · 2020-01-03T13:32:58Z

It's in a PR now, can be reviewed and tested.

odiea · 2020-01-03T13:51:08Z

Works great now. Thanks

odiea · 2020-01-03T14:10:46Z

It appears that it is time to cleanup the old Bintray files?

jekkos · 2020-01-03T15:46:01Z

Ouch i hope it didn't get blocked again?

odiea · 2020-01-03T16:02:18Z

It is currently still working. Just some are 5 months old.

daN4cat · 2020-01-03T18:17:39Z

Merged latest PR

daN4cat · 2020-01-03T22:22:13Z

This seems fixed. I close and preapare Release 3.3.2.

daN4cat · 2020-01-03T22:26:19Z

@klisle when we release 3.3.2, please migrate to that and test is again re-enabling only_full_group_by

objecttothis · 2020-06-28T20:38:11Z

This will be fixed when #2819 gets fixed in 3.4.0. There are a couple of issues caused by Item->search() that will get resolved by removing group_concat() from that function.

jekkos · 2020-10-30T09:56:43Z

WIll close this one, curerntly the setup works but has it's limitations. Improvements are described in #2819

This comment was marked as abuse.

Sign in to view

daN4cat modified the milestones: 3.4.0, 3.3.2 Jan 3, 2020

jekkos added a commit that referenced this issue Jan 3, 2020

Fix item form refresh (#2538)

d52c16f

daN4cat closed this as completed Jan 3, 2020

odiea mentioned this issue Jan 12, 2020

In UBUNTU Server the Add New Item Modal has no fields #2680

Closed

6 tasks

odiea mentioned this issue Mar 6, 2020

Trying adding new items, form appears as blank box. #2750

Closed

7 tasks

odiea mentioned this issue May 25, 2020

New item modal is not loading #2839

Closed

1 task

odiea mentioned this issue Jun 27, 2020

New Item Details Menu Blank #2869

Closed

5 tasks

objecttothis mentioned this issue Jun 28, 2020

Fix Item->search() to resolve issues with attributes #2819

Open

7 tasks

objecttothis modified the milestones: 3.3.2, 3.4.0 Jun 28, 2020

objecttothis reopened this Jun 28, 2020

odiea mentioned this issue Jul 11, 2020

Adding new items seem to be an issue on new install #2888

Closed

6 tasks

jekkos closed this as completed Oct 30, 2020

Make attributes implementation compatible with only_full_group_by #2538

Make attributes implementation compatible with only_full_group_by #2538

Comments

klisle commented Sep 12, 2019

Background information

Installation information

Issue / Bug / Question / New Feature

SteveIreland commented Sep 12, 2019

klisle commented Sep 13, 2019

This comment was marked as abuse.

odiea commented Sep 13, 2019

SteveIreland commented Sep 13, 2019

odiea commented Sep 13, 2019

klisle commented Sep 13, 2019 • edited Loading

This comment was marked as abuse.

odiea commented Sep 13, 2019

klisle commented Sep 13, 2019

klisle commented Sep 13, 2019 • edited Loading

odiea commented Sep 13, 2019

daN4cat commented Sep 13, 2019

klisle commented Sep 13, 2019 • edited Loading

odiea commented Sep 13, 2019

daN4cat commented Sep 13, 2019

klisle commented Sep 13, 2019

daN4cat commented Sep 13, 2019

This comment was marked as abuse.

klisle commented Sep 13, 2019

This comment was marked as abuse.

klisle commented Sep 16, 2019

This comment was marked as abuse.

daN4cat commented Sep 16, 2019

klisle commented Sep 16, 2019

klisle commented Sep 20, 2019 via email

daN4cat commented Sep 20, 2019

klisle commented Sep 23, 2019

daN4cat commented Sep 23, 2019

daN4cat commented Sep 23, 2019 • edited Loading

daN4cat commented Jan 3, 2020 • edited Loading

odiea commented Jan 3, 2020

daN4cat commented Jan 3, 2020

jekkos commented Jan 3, 2020

odiea commented Jan 3, 2020

jekkos commented Jan 3, 2020

jekkos commented Jan 3, 2020

odiea commented Jan 3, 2020

odiea commented Jan 3, 2020

jekkos commented Jan 3, 2020

odiea commented Jan 3, 2020

daN4cat commented Jan 3, 2020

daN4cat commented Jan 3, 2020

daN4cat commented Jan 3, 2020

objecttothis commented Jun 28, 2020

jekkos commented Oct 30, 2020

klisle commented Sep 13, 2019 •

edited

Loading

klisle commented Sep 13, 2019 •

edited

Loading

klisle commented Sep 13, 2019 •

edited

Loading

daN4cat commented Sep 23, 2019 •

edited

Loading

daN4cat commented Jan 3, 2020 •

edited

Loading