Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF vulnerabilities in remove and delete forms #3332

Closed
jekkos opened this issue Oct 4, 2021 · 1 comment
Closed

CSRF vulnerabilities in remove and delete forms #3332

jekkos opened this issue Oct 4, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@jekkos
Copy link
Member

jekkos commented Oct 4, 2021

Some of the forms have CSRF vulnerabilities due to the fact that we allow a GET in the method handling. POST should be enforced everywhere as that would block an attacker into tricking a user with a valid session into triggering form actions on these specific methods.

One case was overlooked and an extra condition is added.

@jekkos jekkos changed the title CSRF vulnerabiliities in remove and delete forms CSRF vulnerabilities in remove and delete forms Oct 4, 2021
@jekkos jekkos self-assigned this Oct 4, 2021
@jekkos jekkos added the bug label Oct 4, 2021
@jekkos jekkos added this to the 3.3.6 milestone Oct 4, 2021
@jekkos jekkos closed this as completed Oct 5, 2021
@daN4cat
Copy link
Collaborator

daN4cat commented Oct 5, 2021

Despite all the work we have done years ago in improving security, there are still issues. It's a constant learning story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants