Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using latest master (3.3.6): add sale, add payment and then cancel payment results in "Method not allowed" #3336

Closed
daN4cat opened this issue Oct 5, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@daN4cat
Copy link
Collaborator

daN4cat commented Oct 5, 2021

I can reproduce this issue with https://dev.opensourcepos.org/ using latest master.
Add an item, add a sale, add a payment, cancel the payment and the page goes blank with "Method not allowed" printed out.

@daN4cat daN4cat added the bug label Oct 5, 2021
@daN4cat daN4cat added this to the 3.3.6 milestone Oct 5, 2021
@daN4cat
Copy link
Collaborator Author

daN4cat commented Oct 5, 2021

Same thing happens if you try to remove an item from the sale register.

@jekkos jekkos self-assigned this Oct 5, 2021
@jekkos
Copy link
Member

jekkos commented Oct 5, 2021

Maybe I have to revert this last change. I must admit that I was too lazy to test the happy case here.

@jekkos
Copy link
Member

jekkos commented Oct 5, 2021

A bit of back and forth but that keeps us going

@daN4cat
Copy link
Collaborator Author

daN4cat commented Oct 6, 2021

Just to be clear, it's not related to supplier/customer remove, it's related to item and payment.
However, if I find the time later I will check if your change solve that problem too.

@odiea
Copy link
Collaborator

odiea commented Oct 6, 2021

This commit may be the issue? Extend method hook validation for deletes.
preg_match('/(save|delete*|remove*)/?\d*?/', $url); does not appear to like this.

@jekkos
Copy link
Member

jekkos commented Oct 16, 2021

should be fixed in master, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants