Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize configuration for docker/host setup #3908

Closed
jekkos opened this issue Dec 22, 2023 · 3 comments
Closed

Harmonize configuration for docker/host setup #3908

jekkos opened this issue Dec 22, 2023 · 3 comments
Assignees
Labels
bug CodeIgniter4 Issue relates to the conversion to CodeIgniter 4
Milestone

Comments

@jekkos
Copy link
Member

jekkos commented Dec 22, 2023

I Did a couple of pushes on the ci4-branch and I've got my dev env running again now, in docker, at last.

There's one thing I'd like to improve which is the config loading. Currently the .env file is used to configure database access. In docker this used to be done through env variables. Those are overwrriten by what is in the .env file, so this is currently broken.

First I was looking for an easy way to prevent the dotenv from overwriting existing environment variables, so if a variable already exists, .env should not touch it. This should only be the case when you run something in docker. The compose files currently have the credentials setup this way.

Or another option is to build a .env file and copy it to the container. From a docker perspective, that might be less transparant and not what you would expect. But the upside is that no special code is needed to handle these overrides.
Will sleep over it and decide on how to tackle this later on.

@jekkos jekkos added bug CodeIgniter4 Issue relates to the conversion to CodeIgniter 4 labels Dec 22, 2023
@jekkos jekkos self-assigned this Dec 22, 2023
jekkos added a commit that referenced this issue Dec 22, 2023
@jekkos jekkos changed the title Harmonize configuration methods for docker/host setup Harmonize configuration for docker/host setup Dec 22, 2023
@jekkos
Copy link
Member Author

jekkos commented Dec 22, 2023

Another issue is that currenty xdebug is not working anymore, so that also needs another look.

@jekkos jekkos added this to the 3.4.0 milestone Dec 22, 2023
jekkos added a commit that referenced this issue Dec 23, 2023
jekkos added a commit that referenced this issue Dec 23, 2023
jekkos added a commit that referenced this issue Dec 23, 2023
jekkos added a commit that referenced this issue Dec 23, 2023
@jekkos
Copy link
Member Author

jekkos commented Dec 23, 2023

XDebug is working again now. Docker config now overrides the settings in .env file, as it should.

jekkos added a commit that referenced this issue Dec 23, 2023
jekkos added a commit that referenced this issue Dec 24, 2023
@jekkos
Copy link
Member Author

jekkos commented Dec 24, 2023

Latest ci4-branch is now deployed on dev. There was a small hiccup in the migration which was that the backup folder was not created. I have fixed this also.

@jekkos jekkos closed this as completed Dec 24, 2023
jekkos added a commit that referenced this issue Jun 10, 2024
jekkos added a commit that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CodeIgniter4 Issue relates to the conversion to CodeIgniter 4
Projects
None yet
Development

No branches or pull requests

1 participant