-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize configuration for docker/host setup #3908
Comments
Another issue is that currenty xdebug is not working anymore, so that also needs another look. |
jekkos
added a commit
that referenced
this issue
Dec 23, 2023
jekkos
added a commit
that referenced
this issue
Dec 23, 2023
jekkos
added a commit
that referenced
this issue
Dec 23, 2023
jekkos
added a commit
that referenced
this issue
Dec 23, 2023
XDebug is working again now. Docker config now overrides the settings in .env file, as it should. |
jekkos
added a commit
that referenced
this issue
Dec 23, 2023
jekkos
added a commit
that referenced
this issue
Dec 24, 2023
Latest ci4-branch is now deployed on dev. There was a small hiccup in the migration which was that the backup folder was not created. I have fixed this also. |
jekkos
added a commit
that referenced
this issue
Jun 10, 2024
jekkos
added a commit
that referenced
this issue
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I Did a couple of pushes on the ci4-branch and I've got my dev env running again now, in docker, at last.
There's one thing I'd like to improve which is the config loading. Currently the .env file is used to configure database access. In docker this used to be done through env variables. Those are overwrriten by what is in the .env file, so this is currently broken.
First I was looking for an easy way to prevent the dotenv from overwriting existing environment variables, so if a variable already exists, .env should not touch it. This should only be the case when you run something in docker. The compose files currently have the credentials setup this way.
Or another option is to build a .env file and copy it to the container. From a docker perspective, that might be less transparant and not what you would expect. But the upside is that no special code is needed to handle these overrides.
Will sleep over it and decide on how to tackle this later on.
The text was updated successfully, but these errors were encountered: