-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: CodeIgniter 4 upgrade #3592
Closed
Closed
Changes from all commits
Commits
Show all changes
641 commits
Select commit
Hold shift + click to select a range
52c8511
CI4 fixes
objecttothis 91d8d68
Moving sql scripts to new location
objecttothis 99bd8f7
Validation for login
objecttothis f490200
Bugfixes
objecttothis 7d41d7b
string interpolation fix
objecttothis 29c9bd8
Bugfixes
objecttothis 977be7a
Debugging routes
objecttothis c6a696f
Changes for CI 4.2.10
objecttothis 4d94437
Changes for CI 4.2.10
objecttothis 1e88ff9
Corrected typos
objecttothis 6895729
Upgraded composer packages
objecttothis bdbc860
Upgrade to CI 4.2.10
objecttothis 3a37863
Upgrade to CI 4.2.10
objecttothis c3e73aa
Package versions
objecttothis 86cc3d9
Remove incompatible package
objecttothis cb073e4
fixed extra comma
objecttothis 666c7d9
Package updates for compatibility
objecttothis 016912d
Updated .htaccess files
objecttothis e4c4b0d
Updated .htaccess files
objecttothis e3647c3
Update language strings to CI4 format
objecttothis c5f8b21
Update language strings to CI4 format
objecttothis f994d5e
Update language strings to CI4 format
objecttothis 6401dda
Added +SymLinksIfOwnerMatch for security
objecttothis 82cb308
Moved Options higher in the htaccess
objecttothis 658d510
Consolidate and move options to the top
objecttothis 1df52d1
CI4 related fixes
objecttothis 03e5092
upgrade spark to latest 4.2.10
objecttothis 2e6d54e
Update Composer to CI 4.3.1
objecttothis 82a03e7
Match some composer.json entries to CI4
objecttothis 4e7b114
CI4 4.3.1 upgrade
objecttothis 8c7f5c1
CI4 4.3.1 upgrade
objecttothis 2fe2a3d
Added missing file and updated composer.lock
objecttothis 04a08f2
Migrations changes
objecttothis b42a1a9
Added required defaults to app\Config\Email.php
objecttothis 4d6a3cc
CI4 updates
objecttothis 3831503
Renamed index to getIndex in Controllers
objecttothis dd7e2f7
Setting Routes
objecttothis 0fad576
Correct redirect() calls to CI4 format
objecttothis d7a3bc2
Fixed index() naming
objecttothis 936ccb9
Bug Fixes
objecttothis 80cabb5
Convert $this->load->vars() to CI4
objecttothis fa1f4af
Login functionality
objecttothis bbb8703
Added .editorconfig
objecttothis 2a7ce12
Converted space indentation to tab
objecttothis 6a9b334
Corrected formatting of login.php view
objecttothis 70f49ac
Fixed migration version check
objecttothis 832e36e
Removed MY_Validation.php
objecttothis 925691e
Temporarily disabling CSRF until we can figure out what parts need to…
objecttothis 3442d81
Fixed Login Validation
objecttothis cdcc858
Updated PHPDoc
objecttothis d6d7b7a
Convert migrations table to CI4 format
objecttothis cdb21d3
Migrations fixes
objecttothis 1a0e5b9
Migrations fixes
objecttothis 62b47a5
Migrations fixes
objecttothis 86395a6
Moved pre-automated migrations scripts
objecttothis dd31231
Updated the CI4 migrations conversion script
objecttothis caf3118
migrations table migration to CI4
objecttothis 98d1904
Fixed bug in CI4 conversion functionality
objecttothis ec14d6d
Return int in get_current_version()
objecttothis f1054f3
moved base scripts to a place that makes more sense
objecttothis c774c1d
Bump dependencies
objecttothis 5d3a8aa
Bump dev dependencies
objecttothis 493289d
Removed vlucas\dotenv.
objecttothis dfa5038
Adjust the build config to allow building the CI4 branch.
SteveIreland e1fb285
Formatting
objecttothis a5d01ae
Corrected the schema of the sessions table
objecttothis 558bef7
Sessions issues. Not fixed yet.
objecttothis 33b0642
Bump dompdf/dompdf from master
objecttothis 7b3a4bb
Bump dompdf/dompdf and picquer dependencies
objecttothis 08b4421
Removed dependency vulnerabilities.
objecttothis 3b46d1c
Added npm-check-updates as a dev-dependency.
objecttothis f129e2f
Fixed CSS in Login view
objecttothis 744f7cf
Fixed CSS in Login view
objecttothis e5c0fb2
Fixed CSS in Login view
objecttothis af14768
Fixed bug preventing view data being passed
objecttothis 17f4a68
Fixed getUri Segment bug
objecttothis 88c7b11
Fixed Commit_sha1 not being found
objecttothis c1c4fe2
fixed language line in en-US
objecttothis 8dd0f41
fixed menu image file references
objecttothis b5c36f9
Match model function signatures to parent
objecttothis f0acd50
Match model function signatures to parent
objecttothis 5022bfa
Added calls to helpers
objecttothis d83a19a
Fix decryption
objecttothis cd96e42
Fix SQL
objecttothis 6e3af91
Fix incorrect function calls
objecttothis 9aec0b4
Fix incorrect function calls
objecttothis 271d146
Fix incorrect function calls
objecttothis bc8c3fd
Simplified boolean comparisons
objecttothis d408675
Fixed sale->update() signature
objecttothis 628c047
Simplified code
objecttothis e508ab8
Typos and correcting variable
objecttothis dcf1bbb
CI4 updates
objecttothis 7b7de41
Caching of ospos_app_config
objecttothis 29997d9
Simplified business logic
objecttothis b149ae6
Reduce calls to config('OSPOS') for speed.
objecttothis 2db77b9
Remove unused function
objecttothis b041f8f
rawurlencode/decode cache data
objecttothis bde3cb2
Replaces calls to config('OSPOS') in views
objecttothis 2dd8a62
Replaces calls to config('OSPOS')
objecttothis 9dc9856
Fixed undefined variable before use.
objecttothis 854b58c
fixed css references
objecttothis d276f99
Autoload cookie helper
objecttothis dd73099
Removed commented code
objecttothis 2150e4d
Fix encryption and missing call
objecttothis f0898f3
Fix for incorrect link generation
objecttothis f3bd534
Added missing initialization of stock_location model
objecttothis 067fd99
Work on language line generation for reports.
objecttothis 319205d
Fixed default language_code
objecttothis 86b47c3
Fix login so that it redirects after migration
objecttothis 03872f0
Working on encryption
objecttothis 7594439
commented out code causing infinite loop.
objecttothis e8b7f22
Added CI3's encryption class as a library
objecttothis 7d78eec
Fix CI4/CI3 encryption compatibility
objecttothis 7738242
Encryption
objecttothis 6126483
Added allowedFields to models
objecttothis dd3b733
Added protected fields for CI4 models
objecttothis 00955b0
Model fixes
objecttothis 51f8910
This revises the build process to handle grunt components requiring t…
SteveIreland bd91576
The first of many tweaks to the reworked build process. This correct…
SteveIreland 8a1e4b2
Convert encryption to CI4
objecttothis 78cfe92
Convert encryption to CI4
objecttothis d8d82aa
Mostly clean up the build documentation, but also corrects an error i…
SteveIreland 32192b9
CI4 bugfixes
objecttothis 715275b
Added missing stock_location model reference
objecttothis 32ba4a9
Remove grunt045 from zipped opensourcepos file. Also fix the call to…
SteveIreland 706adf4
This commit addresses the scenario where encryption fails when the va…
SteveIreland 026ac25
Restore the logout behavior so that when logout is clicked then the u…
SteveIreland 63b0068
Sales MVC
objecttothis c990bb2
Tack on the void return type onto the Employee:logout method.
SteveIreland b23573d
Clone .env to have clean version in case the repository version accid…
SteveIreland d0ddf79
jQuery was one of three javascript files that were not being built co…
SteveIreland ac10b61
If in development mode use the non-minimized verson of the java and c…
SteveIreland 750b2af
A touch of "standards compliance" cleanup.
SteveIreland eb31313
This resolve the issue of the tables not being rendered by removing t…
SteveIreland a9e4283
I believe this batch of changes resolves numerous CI4 related issues …
SteveIreland 7cb4c3e
Correct some experimental code.
SteveIreland 3ec33b6
Correct some experimental code.
SteveIreland f03c75d
More search corrections
SteveIreland 512baf7
Never program while your wife is trying to have a serious discussion …
SteveIreland 80b893a
Corrected model search method naming and added defaults for parameter…
SteveIreland c5180ab
Primary changes return type from ResultSet to int for those requests …
SteveIreland 0ce73cc
These minor changes were needed to get to the point where the Item fo…
SteveIreland 022b2b0
Making these changes allowed me to actually add a new customer. It w…
SteveIreland a207539
Slightly more progress on customer maintenance.
SteveIreland 9ee7b8f
This commit appears to fix customer deletes and updates.
SteveIreland c564deb
This commit renames the get_row ajax call to getAjaxRow in order to l…
SteveIreland b707677
Bulk Controller changes.
SteveIreland 1863db9
Bulk Model changes.
SteveIreland e45dd10
Bulk View changes.
SteveIreland 2288011
A few additional tweaks for customer maintenance
SteveIreland 8cbc915
A few tweaks for item maintenance
SteveIreland ddc9769
It started to seem a little silly and a waste of time to try to keep …
SteveIreland 9c94964
This reworks some things in customer and item maintenance to improve …
SteveIreland 30bf976
Remove a debug statement.
SteveIreland 34ee5cc
More pogress on Item Maintenance.
SteveIreland c70fcdb
Refactored the empty object initialization to make it easier to clone…
SteveIreland 7da6aef
Minor item maintenance changes. Cleaning up so I can restart fresh f…
SteveIreland 9826e54
Removed problematic calls to site_url function.
SteveIreland 54416ae
This cleans up a few more things.
SteveIreland cc604c2
This cleans up a few more things in the area of giftcards.
SteveIreland 5d9eaa4
This got me to the point where I could add an item to a sale.
SteveIreland 71b68a0
For #3698, this commit gets me to the point where I can add, change a…
SteveIreland d879ab6
update int(1) columns in `_customers` and `_cash_up` tables to use ti…
0x85dotdev fbd4e37
Restore the tables.sql to its virgin state.
SteveIreland b5f67ae
For #3730, some progress made on configuration maintenance. More rem…
SteveIreland 35c1ffe
Removes a character that magically appeared out of nowhere.
SteveIreland badc390
For #3730. Discovered that saving the mailchimp credentials without a…
SteveIreland ee21f2a
For #3730. Made more changes to get configuration panels working.
SteveIreland 961419b
For #3730. Fix issue raised by @odiea and cleaned up the checkboxes o…
SteveIreland fa38042
For #3730. More minor corrections to issues found during testing.
SteveIreland 47e2501
For #3730. This corrects errors I encountered doing attribute configu…
SteveIreland 0bfa56f
For #3730. This fixes the inability to add a TEXT field to an item.
SteveIreland 47f4193
For #3730. This replaces FILTER_SANITIZE_STRING with FILTER_SANITIZE_…
SteveIreland 3154b61
For #3730. Prototype of item maintenance changes.
SteveIreland 6ffca6c
For #3730. @odeia raised a couple of issues that needed to be fixed.
SteveIreland 3668f3c
For #3730. This adds a migration script to preload required configura…
SteveIreland 294c6a9
For #3734. This drops the unique index on customer.account_number and…
SteveIreland ae1eebe
For #3730. Another save by @odiea.
SteveIreland 29fabc0
For #3739. Removed unnecessary escaping from customer maintenance.
SteveIreland 2847d36
For #3732. Fixes for reported item maintenance issues.
SteveIreland 2fbc9a4
For #3739. More adjustments for removing esc()
SteveIreland 1f52958
For #3739. More adjustments for removing esc()
SteveIreland 95ba062
Trying my hand at cherry picking master changes into CI4.
awriel 9b80811
For #3698. I'm pleased to announce that this set of changes seems to …
SteveIreland b3678ba
For #3698. Cleanup Attribute.php
SteveIreland f7b9c3b
For #3741. Manual migration of commits from master to branch through …
SteveIreland 1ab8c95
For #3741. Manual migration of commits from master to branch through …
SteveIreland d92225c
For #3741. Manual migration of commits from master to branch through …
SteveIreland 3bcddd6
For #3741. Manual migration of commits from master to branch through …
SteveIreland 3c931a9
For #3741. Manual migration of commits from master to branch through …
SteveIreland e7218b2
For #3741. Manual migration of commits from master to branch through …
SteveIreland 65c85ab
Merge remote-tracking branch 'origin/ci4-upgrade' into ci4-upgrade
SteveIreland 836ffaf
Fixes #3749. This seems to resolve issues with employee maintenance. …
SteveIreland 9353600
For #3749, added the exit() statement after the header was updated.
SteveIreland 01c129e
Bump docker base image to php8
jekkos f6a5b0b
Revert compose file to v2 (#3754)
jekkos 6b8e267
Save Gulp in preparation for migrating these changes over to the ci4 …
SteveIreland 1cdefef
With this commit we are moving from bower and grunt to gulp in order …
SteveIreland c143c35
Fix favicon path in header.php
SteveIreland 9ee0bb1
In Token_lib change App\Models\tokens\Token to App\Models\Tokens\Toke
SteveIreland 97dfdf2
setAttribute should be setTextAttribute for a group separator symbol.
SteveIreland 43781c8
Add fabrication of database.sql to gulp build.
SteveIreland bef33fa
Resolved various issues with item kit maintenance, one of which was r…
SteveIreland 13e0011
Resolved a couple of issues with the Reports panel, one of which was …
SteveIreland c8af68f
Update .travis.yml
jekkos 54ee2dd
Update node image name (#3584)
jekkos 5ef3717
Add back database Dockerfile (#3584)
jekkos 3f87a92
Fix path to database (#3584)
jekkos 7812626
Add tag to sqlscript image (#3584)
jekkos 2f3bde3
Use ci4 composer image (#3584)
jekkos 17d7b74
Update compose files (#3584)
jekkos 9a615fa
Set dev container to development mode (#3584)
jekkos b9af9df
Set CI_ENVIRONMENT in compose files
jekkos 5ec5c69
Set default hostname to localhost (#3584)
jekkos 091614e
Add privileged flag to node (#3584)
jekkos 958a93b
Add missing whitespace (#3584)
jekkos 92e064d
Fix ownership of /app (#3584)
jekkos 7e85cb1
Remove package update for now (#3584)
jekkos f323ec0
Enable apt update again (#3584)
jekkos 4429e48
Bump docker base image (#3584)
jekkos 218e825
Do not install openssl (#3584)
jekkos 00f54ef
Simplify docker config (#3584)
jekkos ab8989c
Correct dockerignore to pick up changes to path folder names.
SteveIreland 8db87fd
In dev mode, allow blank root password.
SteveIreland 60c8ef5
Revert to last working Dockerfile (#3584)
jekkos be8584c
Move first stage to different image (#3584)
jekkos 71df876
Sync language files with master (#3468)
jekkos 0fcf041
added note about intl
objecttothis 68c6fd4
Reinstate en-US files (#3468)
jekkos 2115abe
CI4: string interpolation changes (#3811)
owlbrudder d1f945b
Correct some anomalies around bootstrap_tables_locale.php (#3817)
owlbrudder 1067e68
Handle missing mailchimp api key (#3816)
owlbrudder a78f897
Ci4 enhancement use writable backup (#3815)
owlbrudder 4a0cf52
Add CI4 coding standards linter
jekkos f9277ee
CI4: Bugfix - add function to remove .env.bak issue #3826
owlbrudder 7b9be20
CI4: Bugfix to login.php (#3830)
owlbrudder 821bdc8
CI4: Bugfix correct the removal of env backup
owlbrudder 2628487
Clean up work on reports listing view and lang() methods (#3707)
edwinbsmith 5ef2608
Ci4 bugfix string interpolation (#3836)
owlbrudder 3db105c
Add CI4 language migration scripts (#3468)
jekkos 9993e2d
Sync language files with master (#3468)
jekkos 7a92e76
CI4: Bugfix to correct two config issues
owlbrudder 850bdf4
CI4: Bugfix test sanity of config item
owlbrudder 5fbbccf
Corrected keys for Bootstrap_tables.php
objecttothis 1a1497c
Bump to allow php 8.1
objecttothis 022a9ba
Fix Company logo location
objecttothis 27a8c62
Fix Company logo location
objecttothis b212533
Fix item_pics
objecttothis 246ea27
Fixed incorrect language line
objecttothis 36fc66f
Replaced BASEPATH with FCPATH
objecttothis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
{ | ||
"directory": "public/bower_components", | ||
"scripts": { | ||
"postinstall": "grunt default genlicense", | ||
"postuninstall": "grunt default genlicense" | ||
} | ||
"directory": "public/resources" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
end_of_line = crlf | ||
indent_size = 4 | ||
indent_style = tab | ||
insert_final_newline = true | ||
max_line_length = 120 | ||
tab_width = 4 | ||
|
||
[{*.cjs,*.js}] | ||
indent_style = tab | ||
|
||
[{*.ctp,*.hphp,*.inc,*.module,*.php,*.php4,*.php5,*.phtml}] | ||
indent_style = tab | ||
|
||
[{*.har,*.jsb2,*.jsb3,*.json,.babelrc,.eslintrc,.prettierrc,.stylelintrc,bowerrc,composer.lock,jest.config}] | ||
indent_style = tab | ||
|
||
[{*.htm,*.html,*.ng,*.sht,*.shtm,*.shtml}] | ||
indent_style = tab |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
#-------------------------------------------------------------------- | ||
# ENVIRONMENT | ||
#-------------------------------------------------------------------- | ||
|
||
CI_ENVIRONMENT = production | ||
|
||
#-------------------------------------------------------------------- | ||
# DATABASE | ||
#-------------------------------------------------------------------- | ||
|
||
database.default.hostname = 'localhost' | ||
database.default.database = 'ospos' | ||
database.default.username = 'admin' | ||
database.default.password = 'pointofsale' | ||
database.default.DBDriver = 'MySQLi' | ||
database.default.DBPrefix = 'ospos_' | ||
|
||
database.development.hostname = 'localhost' | ||
database.development.database = 'ospos' | ||
database.development.username = 'admin' | ||
database.development.password = 'pointofsale' | ||
database.development.DBDriver = 'MySQLi' | ||
database.development.DBPrefix = 'ospos_' | ||
|
||
database.tests.hostname = 'localhost' | ||
database.tests.database = 'ospos' | ||
database.tests.username = 'admin' | ||
database.tests.password = 'pointofsale' | ||
database.tests.DBDriver = 'MySQLi' | ||
database.tests.DBPrefix = 'ospos_' | ||
|
||
#-------------------------------------------------------------------- | ||
# ENCRYPTION | ||
#-------------------------------------------------------------------- | ||
|
||
encryption.key = '' | ||
|
||
#-------------------------------------------------------------------- | ||
# LOGGER | ||
# - 0 = Disables logging, Error logging TURNED OFF | ||
# - 1 = Emergency Messages - System is unusable | ||
# - 2 = Alert Messages - Action Must Be Taken Immediately | ||
# - 3 = Critical Messages - Application component unavailable, unexpected exception. | ||
# - 4 = Runtime Errors - Don't need immediate action, but should be monitored. | ||
# - 5 = Warnings - Exceptional occurrences that are not errors. | ||
# - 6 = Notices - Normal but significant events. | ||
# - 7 = Info - Interesting events, like user logging in, etc. | ||
# - 8 = Debug - Detailed debug information. | ||
# - 9 = All Messages | ||
#-------------------------------------------------------------------- | ||
|
||
logger.threshold = 0 | ||
app.db_log_enabled = false | ||
|
||
#-------------------------------------------------------------------- | ||
# HONEYPOT | ||
#-------------------------------------------------------------------- | ||
|
||
honeypot.hidden = true | ||
honeypot.label = 'Fill This Field' | ||
honeypot.name = 'honeypot' | ||
honeypot.template = '<label>{label}</label><input type="text" name="{name}" value=""/>' | ||
honeypot.container = '<div style="display:none">{template}</div>' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
#-------------------------------------------------------------------- | ||
# ENVIRONMENT | ||
#-------------------------------------------------------------------- | ||
|
||
CI_ENVIRONMENT = production | ||
|
||
#-------------------------------------------------------------------- | ||
# DATABASE | ||
#-------------------------------------------------------------------- | ||
|
||
database.default.hostname = 'localhost' | ||
database.default.database = 'ospos' | ||
database.default.username = 'admin' | ||
database.default.password = 'pointofsale' | ||
database.default.DBDriver = 'MySQLi' | ||
database.default.DBPrefix = 'ospos_' | ||
|
||
database.development.hostname = 'localhost' | ||
database.development.database = 'ospos' | ||
database.development.username = 'admin' | ||
database.development.password = 'pointofsale' | ||
database.development.DBDriver = 'MySQLi' | ||
database.development.DBPrefix = 'ospos_' | ||
|
||
database.tests.hostname = 'localhost' | ||
database.tests.database = 'ospos' | ||
database.tests.username = 'admin' | ||
database.tests.password = 'pointofsale' | ||
database.tests.DBDriver = 'MySQLi' | ||
database.tests.DBPrefix = 'ospos_' | ||
|
||
#-------------------------------------------------------------------- | ||
# ENCRYPTION | ||
#-------------------------------------------------------------------- | ||
|
||
encryption.key = '' | ||
|
||
#-------------------------------------------------------------------- | ||
# LOGGER | ||
# - 0 = Disables logging, Error logging TURNED OFF | ||
# - 1 = Emergency Messages - System is unusable | ||
# - 2 = Alert Messages - Action Must Be Taken Immediately | ||
# - 3 = Critical Messages - Application component unavailable, unexpected exception. | ||
# - 4 = Runtime Errors - Don't need immediate action, but should be monitored. | ||
# - 5 = Warnings - Exceptional occurrences that are not errors. | ||
# - 6 = Notices - Normal but significant events. | ||
# - 7 = Info - Interesting events, like user logging in, etc. | ||
# - 8 = Debug - Detailed debug information. | ||
# - 9 = All Messages | ||
#-------------------------------------------------------------------- | ||
|
||
logger.threshold = 0 | ||
app.db_log_enabled = false | ||
|
||
#-------------------------------------------------------------------- | ||
# HONEYPOT | ||
#-------------------------------------------------------------------- | ||
|
||
honeypot.hidden = true | ||
honeypot.label = 'Fill This Field' | ||
honeypot.name = 'honeypot' | ||
honeypot.template = '<label>{label}</label><input type="text" name="{name}" value=""/>' | ||
honeypot.container = '<div style="display:none">{template}</div>' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
dist/ merge=ours | ||
application/language/**/*.php merge=ours | ||
app/Language/**/*.php merge=ours | ||
text=auto |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
name: Coding Standards | ||
|
||
on: | ||
push: | ||
paths: | ||
- '**.php' | ||
- 'spark' | ||
- '.github/workflows/test-coding-standards.yml' | ||
pull_request: | ||
paths: | ||
- '**.php' | ||
- 'spark' | ||
- '.github/workflows/test-coding-standards.yml' | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
lint: | ||
name: PHP ${{ matrix.php-version }} Lint with PHP CS Fixer | ||
runs-on: ubuntu-22.04 | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
php-version: | ||
- '7.4' | ||
- '8.0' | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: ${{ matrix.php-version }} | ||
extensions: tokenizer | ||
coverage: none | ||
|
||
- name: Get composer cache directory | ||
run: echo "COMPOSER_CACHE_FILES_DIR=$(composer config cache-files-dir)" >> $GITHUB_ENV | ||
|
||
- name: Cache dependencies | ||
uses: actions/cache@v3 | ||
with: | ||
path: ${{ env.COMPOSER_CACHE_FILES_DIR }} | ||
key: ${{ runner.os }}-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-${{ matrix.php-version }}- | ||
${{ runner.os }}- | ||
|
||
- name: Install dependencies | ||
run: composer update --ansi --no-interaction | ||
|
||
- name: Run lint on `app/`, `public/` | ||
run: vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --config=.php-cs-fixer.no-header.php --using-cache=no --diff |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense indeed, you're tesing the docker setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You caught me. :-) Yes. I've spent most of this weekend learning Docker, Linux, and trying to make sense of all of the build scripts so that I can help out. I can clean up the obvious stuff, but a lot of it still doesn't make sense or seems overly complicated - but, no doubt that is due to not knowing what I'm doing. I was able to get the mariadb container running, but I was getting three script failures on the ospos container. I just noticed that you made some changes, so I'll pull those and try again, and hopefully have better luck tomorrow. Been reading the docker documentation to get a better grip on how things tie together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool great to hear, I thought I was almost done here but it seems something weird is going on with the travis build, I thought perhaps I'll temporarily build the base image (debian, php and apache) locally and push that, then add the CI4 code to it in the travis build. That will save us build credits but we"ll have to provide security updates ourselves by pushing the base image manually
I had it working at one point but was doing some minor tweaking but now the base install fails and only when I build it on travis. Will give it a go for now and then we can switch back later.