-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item Kits updates for form and Barcodes to show #3949
Conversation
public function Generate Barcodes changed Code to just c and it started working
Yeah, I overlooked that. We need to write a migration script that converts the old value to the new value in the table so that people's current value doesn't get lost |
I pushed a migration script that will onboard everyone to the new codes. If the script doesn't recognize the value, it will default to C128 since that is the most widely usable. |
@odiea can you try it again and tell me if this is still an issue with the latest commits? I'm not able replicate. If it's still an issue, send me a screenshot of your barcode settings in config. |
OK, I see what you're saying now. I didn't understand before that it was in the print dialog. I thought you were saying that the generate barcodes was not working, but it's when you print them. I'll look into this now. |
The problem was being caused by the barcode generator generating DIVs to render the barcode on the screen so that we could set the width in pixels and each barcode would be the same width. I created an issue on their github repo (picqer/php-barcode-generator#194). In the meantime I changed the generation to creating an SVG. The problem is that their SVG (and other) generation techniques take in a width factor, not a desired width. This means that the width of the barcode is based on the length of the data. I submitted a feature request to allow generation to be width based, not factor based. (picqer/php-barcode-generator#195) so we will see what they say. |
* Update Item_kits.php * Update Item_kits.php Barcode Issue public function Generate Barcodes changed Code to just c and it started working
* Update Item_kits.php * Update Item_kits.php Barcode Issue public function Generate Barcodes changed Code to just c and it started working
There may be an issue with the Barcode portion of this update. The Barcode lib version is setting the app config as C128 where the earlier version is setting the app config as Code128. Any ideas would be help full.