Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Kits updates for form and Barcodes to show #3949

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

odiea
Copy link
Collaborator

@odiea odiea commented Mar 12, 2024

There may be an issue with the Barcode portion of this update. The Barcode lib version is setting the app config as C128 where the earlier version is setting the app config as Code128. Any ideas would be help full.

public function Generate Barcodes
changed Code to just c and it started working
@odiea odiea requested a review from objecttothis March 12, 2024 23:58
@objecttothis
Copy link
Member

Yeah, I overlooked that. We need to write a migration script that converts the old value to the new value in the table so that people's current value doesn't get lost

@odiea
Copy link
Collaborator Author

odiea commented Mar 17, 2024

I ran into this issue this morning. This happens in both Items and Item kits but not in Sales Receipts. When I go to print the barcodes the barcode itself does not show.
2024-03-17 05_18_15-Window

@objecttothis
Copy link
Member

There may be an issue with the Barcode portion of this update. The Barcode lib version is setting the app config as C128 where the earlier version is setting the app config as Code128. Any ideas would be help full.

I pushed a migration script that will onboard everyone to the new codes. If the script doesn't recognize the value, it will default to C128 since that is the most widely usable.

@objecttothis objecttothis merged commit 2891192 into opensourcepos:ci4-branch Mar 19, 2024
@objecttothis
Copy link
Member

I ran into this issue this morning. This happens in both Items and Item kits but not in Sales Receipts. When I go to print the barcodes the barcode itself does not show.

@odiea can you try it again and tell me if this is still an issue with the latest commits? I'm not able replicate. If it's still an issue, send me a screenshot of your barcode settings in config.

@odiea
Copy link
Collaborator Author

odiea commented Mar 19, 2024

Let me know what settings you are using. I just did the latest and still have the same issue. No barcode. I have tried multiple settings with no luck.

2024-03-19 03_23_08-Window
2024-03-19 03_24_18-Window

@objecttothis
Copy link
Member

OK, I see what you're saying now. I didn't understand before that it was in the print dialog. I thought you were saying that the generate barcodes was not working, but it's when you print them. I'll look into this now.

@objecttothis
Copy link
Member

The problem was being caused by the barcode generator generating DIVs to render the barcode on the screen so that we could set the width in pixels and each barcode would be the same width. I created an issue on their github repo (picqer/php-barcode-generator#194). In the meantime I changed the generation to creating an SVG. The problem is that their SVG (and other) generation techniques take in a width factor, not a desired width. This means that the width of the barcode is based on the length of the data. I submitted a feature request to allow generation to be width based, not factor based. (picqer/php-barcode-generator#195) so we will see what they say.

jekkos pushed a commit that referenced this pull request Jun 10, 2024
* Update Item_kits.php

* Update Item_kits.php Barcode Issue

public function Generate Barcodes
changed Code to just c and it started working
jekkos pushed a commit that referenced this pull request Jun 15, 2024
* Update Item_kits.php

* Update Item_kits.php Barcode Issue

public function Generate Barcodes
changed Code to just c and it started working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants