Merge pull request FRRouting#8469 from mjstapp/fix_bgp_nhg_mpath

bgpd: don't overrun fixed zapi array of nexthops
opensourcerouting · Apr 15, 2021 · 9759c51 · 9759c51
2 parents 8b74cd9 + 719b209
commit 9759c51
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/bgpd/bgp_evpn_mh.c b/bgpd/bgp_evpn_mh.c
@@ -2493,6 +2493,10 @@ static void bgp_evpn_l3nhg_zebra_add_v4_or_v6(struct bgp_evpn_es_vrf *es_vrf,
 		if (!CHECK_FLAG(es_vtep->flags, BGP_EVPNES_VTEP_ACTIVE))
 			continue;
 
+		/* Don't overrun the zapi buffer. */
+		if (api_nhg.nexthop_num == MULTIPATH_NUM)
+			break;
+
 		/* overwrite the gw */
 		if (v4_nhg)
 			nh.gate.ipv4 = es_vtep->vtep_ip;
@@ -2514,9 +2518,6 @@ static void bgp_evpn_l3nhg_zebra_add_v4_or_v6(struct bgp_evpn_es_vrf *es_vrf,
 	if (!api_nhg.nexthop_num)
 		return;
 
-	if (api_nhg.nexthop_num > MULTIPATH_NUM)
-		return;
-
 	zclient_nhg_send(zclient, ZEBRA_NHG_ADD, &api_nhg);
 }