Rename models to have similar names #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiote tests are failing on Travis. |
| fields=[ | ||
| ('id', models.CharField(serialize=False, primary_key=True, max_length=2)), | ||
| ('id', models.CharField(max_length=2, serialize=False, primary_key=True)), |
There was a problem hiding this comment.
Also add the 3 letter variant too. Maybe an array field called codes which lists all the codes for the country (including the one we use as id).
There was a problem hiding this comment.
from django_cities we have 3 letters code already: in code3 field (Char, as django_cities offers only one code for one country). Is that enough?
|
Better to keep the serialisers as they were. It is always useful and important to have minimal serialisers for nesting in other objects, especially as payloads get bigger and we add more things. |
kiote
force-pushed
the
feature/untied-models2
branch
from
e0a37c5
to
bb09f89
Compare
Okay, I'll bring them back :) |
kiote
force-pushed
the
feature/untied-models2
branch
from
bb09f89
to
9661b3f
Compare
disconnect cosmopolitan models with django_cities models related to openspending#8
kiote
force-pushed
the
feature/untied-models2
branch
from
9661b3f
to
fc6f8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disconnect cosmopolitan models with django_cities models
related to #8
I did this with several steps, but for commit merged them to one, so here is bit too much happens.
Continent->CosmopolitanContinent,Currency->CosmopolitanCurrency,ExtraCountry->CosmopolitanCountrydjango_citiesmodels (so no references there now).nameamong of params (before -detail views has onlyidandurl).