Bump python version to 3.6, fix tests for redis timeout, fix up travis/coveralls reporting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests/__init__.py to coverage works, and add coverage to .travis.yml.
RedisCache timeout for expiring keys can be set with a default_timeout during cache creation, or (for first access) with a timeout when putting the item. After first access the default_timeout is reset.
tox.ini
Outdated
| envlist= | ||
| py35 | ||
| py36 | ||
| skip_missing_interpreters = true |
There was a problem hiding this comment.
Same small tweak, no point skipping missing interpreters if you just have one. However, it doesn't matter much anyway.
vitorbaptista
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the python version to 3.6 and fixes tests to reflect RedisCache timeout behaviour.
This PR is part of openspending/openspending#1302
RedisCache timeout for expiring items can be set either during creation of the cache, with a
default_timeout, or when putting an item into the cache, with atimeoutparameter.put,default_timeoutwill be used.os-api-cache/os_api_cache/base_cache.py
Line 11 in 5114374
os-api-cache/os_api_cache/base_cache.py
Lines 21 to 24 in 5114374
default_timeoutwill be reset on it.os-api-cache/os_api_cache/redis_cache.py
Lines 29 to 30 in 5114374
put, the item will be set to expire after that time. However, if it accessed within that time, a new expire timeout is set to thedefault_timeoutvalue.