Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 if package id for /info endpoint isn't found #16

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Return 404 if package id for /info endpoint isn't found #16

merged 2 commits into from
Dec 12, 2017

Conversation

brew
Copy link
Contributor

@brew brew commented Dec 7, 2017

Currently, the view function doesn't return a valid response if a model isn't found for the slug. This PR aborts the response with a 404.

Fixes openspending/openspending#1331.

vitorbaptista
vitorbaptista approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@vitorbaptista vitorbaptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't run the code, but it looks good 👍

@brew brew merged commit fdac594 into master Dec 12, 2017
@brew brew removed the in progress label Dec 12, 2017
@brew brew deleted the 1331/undefined-package branch December 12, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorbaptista vitorbaptista vitorbaptista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brew @vitorbaptista