Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation #146

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Conversation

Vanuan
Copy link
Contributor

@Vanuan Vanuan commented Dec 5, 2016

I hope that's the correct file to edit.

@kravets-levko
Copy link
Contributor

kravets-levko commented Dec 5, 2016

Hi @Vanuan! Please move translations to translations folder (see translations/de.json as example), and run download_translations.py (use python 3) to update app/config/translations.json.

"Analyse this data set in the Data Mine": "Аналізувати цей набір даних у Data Mine",
"Available visualizations": "Наявні візуалізації",
"Bar Chart": "Гістограмма",
"Bubble Tree": "Ієрархічна бульбашка",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 😄

"Budgetary Transfers": "Бюджетні трасфери",
"Clear": "Очистити",
"Columns": "Колонки",
"Create visualisation and select a view of your choice": "Створити візуалізацію та обрати представлення даних",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO "обрати подання даних" will be a bit better; but it's on you own.

"Tree Map": "Ієрархічна карта",
"Unknown": "Невідомо",
"Value Formatting Scale": "\"мільярдів\": 1000000000, \"мільйонів\": 1000000, \"тисяч\": 1000",
"View Raw Source Data": "Показати сирі початкові дані",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO "Показати вихідні дані" will be a bit better; but it's on you own.

@Vanuan
Copy link
Contributor Author

Vanuan commented Dec 5, 2016

Moved to translations/, considered suggestions.

@kravets-levko
Copy link
Contributor

Cool, thank you. Can you also run download_translations.py?

@Vanuan
Copy link
Contributor Author

Vanuan commented Dec 5, 2016

UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 29: ordinal not in range(128)

Looks like it doesn't support UTF-8 JSON files?

@Vanuan
Copy link
Contributor Author

Vanuan commented Dec 5, 2016

Traceback (most recent call last):
  File "./download_translations.py", line 49, in <module>
    main()
  File "./download_translations.py", line 40, in main
    result.update(load_spreadsheet(URL))
  File "./download_translations.py", line 27, in load_spreadsheet
    for row in reader:

"Unknown": "Невідомо",
"Value Formatting Scale": "\"мільярдів\": 1000000000, \"мільйонів\": 1000000, \"тисяч\": 1000",
"View Raw Source Data": "Показати вихідні дані",
"X-Axis": "Ось X",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I missed it earlier. Mistake: use "Вісь X" instead.

@kravets-levko
Copy link
Contributor

Try python3: python3 download_translations.py

@Vanuan
Copy link
Contributor Author

Vanuan commented Dec 5, 2016

Done

@kravets-levko
Copy link
Contributor

Great job, thank you! Merging now

@kravets-levko kravets-levko merged commit 716f8d9 into openspending:master Dec 5, 2016
@Vanuan Vanuan deleted the patch-1 branch December 5, 2016 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants