Add configs

[mattfullerton]

Ability to use local file storage instead of s3
Ability to serve to only certain IPs (useful when using a test instance for embargoed data)

[pudo]

I obviously love the file support, but the limit IP thing seems to me like something that should be done in a higher-level web server (nginx, apache). Are you sure we need it in core?

[mattfullerton]

We absolutely do not :) But when quickly developing something on a home PC I have neither nginx, apache or AWS security groups (and this could be quite a common developer use case... embargoed data etc). Would you like me to prune down the PR?

[pudo]

wdyt, @pwalsh @milafrerichs ?

[pwalsh]

File support is excellent. Very much looking forward to getting this into OS.

As for the IP limit thing, I think it is fine here, and useful as @mattfullerton points out. I've personally done this type of thing on various django and flask code bases.

[breyten]

+1 for file support. As for the IP settings maybe something like this:

allowed_ips = app.config.get('ALLOWED_IPS', [])
if len(allowed_ips) > 0 and request.remote_addr not in allowed_ips:
    abort(403)

This way you have one setting, instead of two. (But this is a bit of nitpicking ;))

[milafrerichs]

File support is excellent. But I would rather see the settings made available via the environment.

e.g.:

STORAGE_TYPE = env('SPENDB_STORAGE_TYPE', 's3')
STORAGE_PATH = env('SPENDB_STORAGE_PATH', 'default/path')

not sure about the IP limiting...

[pudo]

Hm, so I really do feel like this would be better to keep apart and merge the storage, while keeping the IP filtering to front-end tools?

[mattfullerton]

OK, I've removed IP support and added defaults/env variable loading as suggested by @milafrerichs

[milafrerichs]

no need to define it twice. can you remove the lines 22 & 23?

[milafrerichs]

see the comment, otherwise looks great. thanks @mattfullerton

[mattfullerton]

@milafrerichs that's what happens to commits at 7:23... removed the duplication

[pudo]

You guys rock :)