Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Engine and SDK Artifacts #2495

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Migrate Engine and SDK Artifacts #2495

merged 1 commit into from
Jun 26, 2023

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented Jun 26, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

This PR will migrate to latest SDK engine which will enable us to take advantage of the Performance enhancements me covered by this PR google/android-fhir#2047

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2495 (6241235) into main (2ea8fa1) will increase coverage by 0.4%.
The diff coverage is 64.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2495     +/-   ##
=========================================
+ Coverage     64.8%   65.3%   +0.4%     
- Complexity    1050    1086     +36     
=========================================
  Files          209     211      +2     
  Lines         9156    9331    +175     
  Branches      1805    1858     +53     
=========================================
+ Hits          5942    6097    +155     
+ Misses        2059    2039     -20     
- Partials      1155    1195     +40     
Flag Coverage Δ
engine 72.8% <65.2%> (-0.3%) ⬇️
geowidget 63.2% <ø> (ø)
quest 60.4% <64.2%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ine/configuration/view/ViewPropertiesSerializer.kt 25.0% <0.0%> (-1.4%) ⬇️
...e/engine/ui/bottomsheet/RegisterBottomSheetView.kt 51.2% <0.0%> (-2.5%) ⬇️
...g/smartregister/fhircore/quest/QuestApplication.kt 44.2% <ø> (+0.8%) ⬆️
...hircore/quest/ui/shared/components/CompoundText.kt 75.2% <0.0%> (-0.9%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 67.1% <0.0%> (-2.9%) ⬇️
...rcore/quest/ui/usersetting/UserSettingViewModel.kt 61.9% <29.4%> (-9.5%) ⬇️
...core/engine/configuration/view/ButtonProperties.kt 48.8% <33.3%> (-3.4%) ⬇️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 73.2% <33.3%> (-1.3%) ⬇️
...rcore/engine/configuration/view/ImageProperties.kt 34.6% <34.6%> (ø)
...gine/ui/bottomsheet/RegisterBottomSheetFragment.kt 37.5% <50.0%> (+1.7%) ⬆️
... and 27 more

... and 5 files with indirect coverage changes

@ndegwamartin ndegwamartin merged commit b69fb5b into main Jun 26, 2023
@ndegwamartin ndegwamartin deleted the migrate-sdk-j26 branch June 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants