Add the new eCBIS flavor | main #2610
Conversation
android/quest/build.gradle.kts
Outdated
| create("ecbis_liberia") { | ||
| dimension = "apps" | ||
| applicationIdSuffix = ".ecbis_liberia" | ||
| versionNameSuffix = "-ecbis_liberia" | ||
| manifestPlaceholders["appLabel"] = "MOH eCBIS" |
There was a problem hiding this comment.
ah so we're going to make the current one preview and have the new one be production? I think we can put "production" in the name instead of "liberia" for clarity
There was a problem hiding this comment.
I think we should do the reverse since the production app is what the client will interact with even on Playstore and should be concise, that is
- For prod - the flavor should be
ecbisand the suffix.ecbis - For preview - the flavor should be
ecbis_previewand the suffix.ecbis_preview
There was a problem hiding this comment.
@ndegwamartin The thinking on the change was to force them to download the new prod APK. If we use the same package name they will just update which means they don't clear the existing preview data on the device. I am also not sure if the server URL will be correctly updated.
There was a problem hiding this comment.
If we are unable to enforce the integrity for a fresh install then I suppose we can follow that approach. We will however need a new Playstore release APK upload and verification process for the new application id cc @pld
There was a problem hiding this comment.
That's a nice catch. Does the mean we need to de-list the current app?
There was a problem hiding this comment.
k so then we'd have 2 releases on play store the prod and preview one? I'm fine w/that, I'd worry a bit that if we have to de-list the current app, we take the risk of delay on getting up a new app
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
+ Coverage 29.6% 60.6% +30.9%
- Complexity 658 1067 +409
==========================================
Files 239 247 +8
Lines 11204 9979 -1225
Branches 1948 1778 -170
==========================================
+ Hits 3323 6049 +2726
+ Misses 7447 2897 -4550
- Partials 434 1033 +599
Flags with carried forward coverage won't be shown. Click here to find out more. |
…rcore into feature/add_new_ecbis_flavor
dubdabasoduba
changed the title
…itioner id fetch Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
There was a problem hiding this comment.
shouldn't we use the ecbis logo w/a banner over it or something
There was a problem hiding this comment.
We wanted the distinction on the installation hence the need to use different icons.
I will be updating the configs on preview to change the app name on the UI to read preview too
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
android/quest/src/main/java/org/smartregister/fhircore/quest/ui/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
…i/login/LoginViewModel.kt
|
@dubdabasoduba Do we still need to merge this PR? |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile