Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the new eCBIS flavor | main #2610

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add the new eCBIS flavor | main #2610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
23a9cee
Add the new eCBIS flavor
dubdabasoduba Jul 20, 2023
20c76a7
Merge branch 'main' into feature/add_new_ecbis_flavor
pld Jul 20, 2023
74bd8ee
Update the flavor naming
dubdabasoduba Jul 21, 2023
ddc90a3
Merge branch 'feature/add_new_ecbis_flavor' of github.com:opensrp/fhi…
dubdabasoduba Jul 21, 2023
289b2ff
Update changelog
dubdabasoduba Jul 21, 2023
73412dc
Merge branch 'main' into feature/add_new_ecbis_flavor
dubdabasoduba Jul 21, 2023
2d50993
Merge branch 'main' into feature/add_new_ecbis_flavor
dubdabasoduba Jul 25, 2023
2119f59
Update the flavor naming
dubdabasoduba Jul 25, 2023
b5fc566
Move assets to the correct folder
dubdabasoduba Jul 25, 2023
2e18c66
Updating the ecbis flavor and updating the practitioner details pract…
dubdabasoduba Jul 25, 2023
2dad6bf
Fix broken tasks
dubdabasoduba Jul 25, 2023
1e061aa
Merge branch 'main' into feature/add_new_ecbis_flavor
dubdabasoduba Aug 1, 2023
71dc93c
Merge branch 'main' of github.com:opensrp/fhircore into feature/add_n…
dubdabasoduba Aug 16, 2023
70f372e
Fix changelog
dubdabasoduba Aug 16, 2023
6d218e1
Merge branch 'main' of github.com:opensrp/fhircore into feature/add_n…
dubdabasoduba Aug 16, 2023
b089366
Update android/quest/src/main/java/org/smartregister/fhircore/quest/u…
pld Aug 16, 2023
c316f55
Merge branch 'main' into feature/add_new_ecbis_flavor
pld Aug 16, 2023
a3deafd
Merge branch 'main' into feature/add_new_ecbis_flavor
dubdabasoduba Apr 30, 2024
2007e0e
Merge branch 'main' into feature/add_new_ecbis_flavor
dubdabasoduba Jun 14, 2024
52cb3b6
Merge branch 'main' into feature/add_new_ecbis_flavor
pld Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions android/quest/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ android {
dimension = "apps"
applicationIdSuffix = ".ecbis"
versionNameSuffix = "-ecbis"
manifestPlaceholders["appLabel"] = "MOH eCBIS Preview"
}

create("ecbis_liberia") {
dimension = "apps"
applicationIdSuffix = ".ecbis_liberia"
versionNameSuffix = "-ecbis_liberia"
manifestPlaceholders["appLabel"] = "MOH eCBIS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so we're going to make the current one preview and have the new one be production? I think we can put "production" in the name instead of "liberia" for clarity

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do the reverse since the production app is what the client will interact with even on Playstore and should be concise, that is

  • For prod - the flavor should be ecbis and the suffix .ecbis
  • For preview - the flavor should be ecbis_preview and the suffix .ecbis_preview

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndegwamartin The thinking on the change was to force them to download the new prod APK. If we use the same package name they will just update which means they don't clear the existing preview data on the device. I am also not sure if the server URL will be correctly updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are unable to enforce the integrity for a fresh install then I suppose we can follow that approach. We will however need a new Playstore release APK upload and verification process for the new application id cc @pld

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice catch. Does the mean we need to de-list the current app?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k so then we'd have 2 releases on play store the prod and preview one? I'm fine w/that, I'd worry a bit that if we have to de-list the current app, we take the risk of delay on getting up a new app

}

Expand Down
Binary file added android/quest/src/ecbis/res/drawable/ic_app_logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added android/quest/src/ecbis/res/drawable/ic_launcher.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
0 ...st/src/ecbis/res/drawable/ic_app_logo.xml → ...cbis_liberia/res/drawable/ic_app_logo.xml
View file
Open in desktop
File renamed without changes.
0 ...st/src/ecbis/res/drawable/ic_launcher.xml → ...cbis_liberia/res/drawable/ic_launcher.xml
View file
Open in desktop
File renamed without changes.
Loading