-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display data migration in settings #3079
Open
AbdulWahabMemon
wants to merge
14
commits into
main
Choose a base branch
from
display-data-migration-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3079 +/- ##
=========================================
- Coverage 28.3% 28.0% -0.4%
+ Complexity 716 715 -1
=========================================
Files 266 265 -1
Lines 12760 12825 +65
Branches 2265 2304 +39
=========================================
- Hits 3621 3596 -25
- Misses 8666 8759 +93
+ Partials 473 470 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* main: Add test Fix failing test Update docs Make app title visibility configurable
* main: add docs on tagging (#3089) Constrain isAAB option to Boolean type (#3093) Create manual-apk-release.yml (#3003) Fix setting related entity location on Group member and related resources (#3092) Enhance Image and ActionableButton Widget to add ability to copy text (#3040) Add Related entity location tag on newly created resources via configs (#3086) Spotless clean Fixes config resources flagged for upsync 🐛 Clean up
Is this PR read for review? @AbdulWahabMemon |
ellykits
requested changes
May 13, 2024
android/engine/src/main/java/org/smartregister/fhircore/engine/util/SharedPreferenceKey.kt
Outdated
Show resolved
Hide resolved
.../quest/src/main/java/org/smartregister/fhircore/quest/ui/usersetting/UserSettingViewModel.kt
Outdated
Show resolved
Hide resolved
ellykits
requested changes
May 14, 2024
android/quest/src/main/java/org/smartregister/fhircore/quest/data/DataMigration.kt
Outdated
Show resolved
Hide resolved
android/quest/src/main/java/org/smartregister/fhircore/quest/data/DataMigration.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # android/engine/src/main/java/org/smartregister/fhircore/engine/util/SharedPreferenceKey.kt
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file