Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display data migration in settings #3079

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

AbdulWahabMemon
Copy link
Contributor

@AbdulWahabMemon AbdulWahabMemon commented Feb 19, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.0%. Comparing base (83595aa) to head (f869d92).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3079     +/-   ##
=========================================
- Coverage     28.3%   28.0%   -0.4%     
+ Complexity     716     715      -1     
=========================================
  Files          266     265      -1     
  Lines        12760   12825     +65     
  Branches      2265    2304     +39     
=========================================
- Hits          3621    3596     -25     
- Misses        8666    8759     +93     
+ Partials       473     470      -3     
Flag Coverage Δ
engine 64.9% <ø> (-0.1%) ⬇️
geowidget 12.8% <ø> (-7.0%) ⬇️
quest 4.7% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ircore/quest/ui/usersetting/UserSettingFragment.kt 19.1% <0.0%> (-0.3%) ⬇️
...rcore/quest/ui/usersetting/UserSettingViewModel.kt 4.2% <0.0%> (-0.2%) ⬇️
...fhircore/quest/ui/usersetting/UserSettingScreen.kt 2.2% <0.0%> (-0.1%) ⬇️

... and 1 file with indirect coverage changes

* main:
  Add test
  Fix failing test
  Update docs
  Make app title visibility configurable
* main:
  add docs on tagging (#3089)
  Constrain isAAB option to Boolean type (#3093)
  Create manual-apk-release.yml (#3003)
  Fix setting related entity location on Group member and related resources (#3092)
  Enhance Image and ActionableButton Widget to add ability to copy text (#3040)
  Add Related entity location tag on newly created resources via configs (#3086)
  Spotless clean
  Fixes config resources flagged for upsync 🐛
  Clean up
@ellykits
Copy link
Collaborator

Is this PR read for review? @AbdulWahabMemon

@AbdulWahabMemon AbdulWahabMemon marked this pull request as ready for review May 7, 2024 10:44
@AbdulWahabMemon
Copy link
Contributor Author

@ellykits your feedback is addressed,
kindly re-review,
app is also tested on stag with ecbisDebug,, app displays data-migration version 0 without any error or crash

cc: @ageryck

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits changed the title display data-migration-version in User Settings Page Display data migration in settings Jul 19, 2024
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants