-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eir demo flavor #3102
Merged
Merged
eir demo flavor #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
- Coverage 64.5% 29.8% -34.7%
+ Complexity 1075 652 -423
==========================================
Files 218 236 +18
Lines 9635 11059 +1424
Branches 1897 1925 +28
==========================================
- Hits 6218 3306 -2912
- Misses 2234 7323 +5089
+ Partials 1183 430 -753
Flags with carried forward coverage won't be shown. Click here to find out more. |
pld
approved these changes
Feb 26, 2024
Lentumunai-Mark
pushed a commit
that referenced
this pull request
Feb 27, 2024
ellykits
added a commit
that referenced
this pull request
May 14, 2024
…#3107) * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Update tests WIP Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Use subject's Related Entity Location meta tag on related resources (#3097) * Use subject's Related Entity Location meta tag on related resources --------- Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: pld <peter@ona.io> * eir demo flavor (#3102) * update admin-dashboard-feature docs (#3084) Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com> * Add location service with Preference feature. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Resolve conflicts Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Run spotless apply. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Run spotless Apply. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Add deny permission for UI automator Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Grant permission on tests where required. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Remove unused functions. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * rename function to be more descriptive. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Adress PR feedback provided. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Format files changed by running spotlessApply Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Update application config to remove outdated variables * Use data store on Location service Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Change grant permission rule. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * fix spotless check Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Change how we're accessing permission rule. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Run spotless check. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Try resolve failing test. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Add permission granted rule. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Add @ignore to the failing tests Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Test commit, trying out new CI fixes. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Fix spotless check Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Update AppMainActivityTest.kt * Fix spotless check failing. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> --------- Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: pld <peter@ona.io> Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com> Co-authored-by: Owais <62104757+owais-vd@users.noreply.github.com> Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Generic EIR Demo
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file