Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eir demo flavor #3102

Merged
merged 1 commit into from
Feb 26, 2024
Merged

eir demo flavor #3102

merged 1 commit into from
Feb 26, 2024

Conversation

roywanyaga
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Generic EIR Demo

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.8%. Comparing base (ad3a737) to head (7723aa3).
Report is 184 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main   #3102      +/-   ##
==========================================
- Coverage     64.5%   29.8%   -34.7%     
+ Complexity    1075     652     -423     
==========================================
  Files          218     236      +18     
  Lines         9635   11059    +1424     
  Branches      1897    1925      +28     
==========================================
- Hits          6218    3306    -2912     
- Misses        2234    7323    +5089     
+ Partials      1183     430     -753     
Flag Coverage Δ
engine 66.2% <ø> (-6.5%) ⬇️
geowidget 47.2% <ø> (-17.1%) ⬇️
quest 5.3% <ø> (-53.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 127 files with indirect coverage changes

@pld pld merged commit 562cae9 into main Feb 26, 2024
5 checks passed
@pld pld deleted the eir-demo-flavor branch February 26, 2024 17:48
AbdulWahabMemon added a commit that referenced this pull request Feb 26, 2024
* main:
  update admin-dashboard-feature docs (#3084)
  eir demo flavor (#3102)
  Use subject's Related Entity Location meta tag on related resources (#3097)
Lentumunai-Mark pushed a commit that referenced this pull request Feb 27, 2024
AbdulWahabMemon added a commit that referenced this pull request Feb 28, 2024
* main:
  update admin-dashboard-feature docs (#3084)
  eir demo flavor (#3102)
  Use subject's Related Entity Location meta tag on related resources (#3097)
ellykits added a commit that referenced this pull request May 14, 2024
…#3107)

* Add location service with Preference feature.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Update tests WIP

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Use subject's Related Entity Location meta tag on related resources (#3097)

* Use subject's Related Entity Location meta tag on related resources
---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: pld <peter@ona.io>

* eir demo flavor (#3102)

* update admin-dashboard-feature docs (#3084)

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>

* Add location service with Preference feature.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Resolve conflicts

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Run spotless apply.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Run spotless Apply.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Add deny permission for UI automator

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Grant permission on tests where required.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Remove unused functions.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* rename function to be more descriptive.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Adress PR feedback provided.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Format files changed by running spotlessApply

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Update application config to remove outdated variables

* Use data store on Location service

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Change grant permission rule.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* fix spotless check

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Change how we're accessing permission rule.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Run spotless check.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Try resolve failing test.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Add permission granted rule.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Add @ignore to the failing tests

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Test commit, trying out new CI fixes.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix spotless check

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Update AppMainActivityTest.kt

* Fix spotless check failing.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

---------

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: pld <peter@ona.io>
Co-authored-by: Roy <84201465+roywanyaga@users.noreply.github.com>
Co-authored-by: Owais <62104757+owais-vd@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants