Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feature to compute distance between two locations via Rules #3107

Merged
merged 61 commits into from
May 14, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark commented Feb 27, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3039
Fixes #https://github.com/onaio/fhir-resources/issues/2947

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Lentumunai-Mark and others added 7 commits February 26, 2024 19:30
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
…3097)

* Use subject's Related Entity Location meta tag on related resources
---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: pld <peter@ona.io>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@Lentumunai-Mark Lentumunai-Mark changed the base branch from questionnaire-location to main February 27, 2024 06:32
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 32.06522% with 125 lines in your changes are missing coverage. Please review.

Project coverage is 29.9%. Comparing base (ac82739) to head (60328be).
Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3107     +/-   ##
=========================================
+ Coverage     29.6%   29.9%   +0.3%     
- Complexity     658     673     +15     
=========================================
  Files          239     243      +4     
  Lines        11204   11431    +227     
  Branches      1948    1981     +33     
=========================================
+ Hits          3323    3429    +106     
- Misses        7447    7553    +106     
- Partials       434     449     +15     
Flag Coverage Δ
geowidget 47.2% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gister/fhircore/engine/rulesengine/RulesFactory.kt 69.6% <100.0%> (+0.3%) ⬆️
...gister/fhircore/engine/util/SharedPreferenceKey.kt 100.0% <100.0%> (ø)
.../engine/rulesengine/services/LocationCoordinate.kt 85.7% <85.7%> (ø)
...r/fhircore/engine/util/location/PermissionUtils.kt 0.0% <0.0%> (ø)
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 3.2% <0.0%> (+0.3%) ⬆️
...gister/fhircore/engine/datastore/ProtoDataStore.kt 65.9% <58.8%> (+0.3%) ⬆️
...store/serializers/LocationCoordinatesSerializer.kt 42.8% <42.8%> (ø)
...fhircore/engine/util/adapter/InstantTypeAdapter.kt 0.0% <0.0%> (ø)
...ore/engine/rulesengine/services/LocationService.kt 73.9% <73.9%> (ø)
...ter/fhircore/engine/util/location/LocationUtils.kt 0.0% <0.0%> (ø)
... and 1 more

... and 6 files with indirect coverage changes

Lentumunai-Mark and others added 12 commits February 29, 2024 12:01
…-Location-Service-v2

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
dubdabasoduba and others added 13 commits April 18, 2024 10:14
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@ndegwamartin
Copy link
Contributor

@marklosh since the feature is tested and working and the tests are running on CI lets merge this in and track the CI issue on a separate ticket. You can @ignore the failing test case for now.

Please create the new ticket with the details.

@Lentumunai-Mark
Copy link
Contributor Author

@ndegwamartin here is the ticket #3251

@ellykits ellykits merged commit a3ff6f2 into main May 14, 2024
3 checks passed
@ellykits ellykits deleted the Add-Location-Service-v2 branch May 14, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to calculate distance between 2 locations
7 participants