Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync progress enhancement work. #3332

Merged
merged 56 commits into from
Aug 2, 2024
Merged

Sync progress enhancement work. #3332

merged 56 commits into from
Aug 2, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3295
Fixes #3294

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Lentumunai-Mark and others added 2 commits June 12, 2024 17:17
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 2.05224% with 525 lines in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (38bf5b4) to head (89e1992).
Report is 2 commits behind head on main.

Files Patch % Lines
...ter/fhircore/quest/ui/main/components/AppDrawer.kt 0.0% 177 Missing ⚠️
...rcore/quest/ui/shared/components/SyncStatusView.kt 0.0% 117 Missing ⚠️
...ister/fhircore/quest/ui/register/RegisterScreen.kt 0.0% 104 Missing ⚠️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 0.0% 37 Missing and 1 partial ⚠️
...ore/quest/ui/launcher/GeoWidgetLauncherFragment.kt 0.0% 28 Missing ⚠️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 0.0% 19 Missing ⚠️
...ircore/quest/ui/usersetting/UserSettingFragment.kt 0.0% 12 Missing ⚠️
...register/fhircore/quest/ui/main/AppMainActivity.kt 0.0% 10 Missing ⚠️
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% 9 Missing ⚠️
...re/quest/ui/launcher/GeoWidgetLauncherViewModel.kt 0.0% 6 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3332     +/-   ##
=========================================
- Coverage     28.0%   27.3%   -0.8%     
- Complexity     719     720      +1     
=========================================
  Files          267     269      +2     
  Lines        12961   13411    +450     
  Branches      2327    2427    +100     
=========================================
+ Hits          3641    3666     +25     
- Misses        8840    9263    +423     
- Partials       480     482      +2     
Flag Coverage Δ
engine 64.6% <100.0%> (-0.2%) ⬇️
geowidget 11.4% <ø> (-1.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/smartregister/fhircore/engine/ui/theme/Colors.kt 97.4% <100.0%> (+<0.1%) ⬆️
...tregister/fhircore/quest/ui/main/AppMainUiState.kt 96.2% <100.0%> (+0.4%) ⬆️
...ster/fhircore/quest/ui/register/RegisterUiState.kt 100.0% <100.0%> (ø)
...hircore/quest/ui/shared/models/AppDrawerUIState.kt 100.0% <100.0%> (ø)
...artregister/fhircore/quest/ui/main/AppMainEvent.kt 94.4% <0.0%> (-5.6%) ⬇️
...ister/fhircore/quest/ui/shared/components/Image.kt 0.0% <0.0%> (ø)
...re/quest/ui/launcher/GeoWidgetLauncherViewModel.kt 0.0% <0.0%> (ø)
...er/fhircore/quest/ui/register/RegisterViewModel.kt 0.0% <0.0%> (ø)
...register/fhircore/quest/ui/main/AppMainActivity.kt 0.0% <0.0%> (ø)
...ircore/quest/ui/usersetting/UserSettingFragment.kt 20.0% <0.0%> (+0.8%) ⬆️
... and 6 more

... and 5 files with indirect coverage changes

Lentumunai-Mark and others added 4 commits June 14, 2024 09:41
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com>
@ellykits
Copy link
Collaborator

@Lentumunai-Mark Can you share screenshot or animated gif for this?

@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review June 24, 2024 06:02
Lentumunai-Mark and others added 8 commits June 24, 2024 12:06
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@ellykits
Copy link
Collaborator

ellykits commented Jul 8, 2024

@Lentumunai-Mark on the UI I still get the snackbar notifications? Was this intended?

@Lentumunai-Mark
Copy link
Contributor Author

@Lentumunai-Mark on the UI I still get the snackbar notifications? Was this intended?

@ellykits will resolve this.

@Lentumunai-Mark Lentumunai-Mark marked this pull request as draft July 16, 2024 11:52
Lentumunai-Mark and others added 3 commits July 16, 2024 14:52
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@ellykits
Copy link
Collaborator

@Lentumunai-Mark Observe the sync states for geowidget map that also uses the app drawer

dubdabasoduba and others added 15 commits July 19, 2024 10:41
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@ellykits ellykits self-assigned this Jul 31, 2024
@ellykits ellykits added the Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions label Jul 31, 2024
Lentumunai-Mark and others added 8 commits July 31, 2024 19:16
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits merged commit 2998a84 into main Aug 2, 2024
4 of 5 checks passed
@ellykits ellykits deleted the sync-progress-enhancement branch August 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Projects
None yet
4 participants