Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get RelatedPerson Age and Gender via Rules Engine #3384

Merged
merged 10 commits into from
Jul 17, 2024

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Jul 16, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (70a8bc1) to head (e80924c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3384   +/-   ##
=======================================
  Coverage     28.2%   28.2%           
  Complexity     713     713           
=======================================
  Files          266     266           
  Lines        12728   12737    +9     
  Branches      2258    2264    +6     
=======================================
+ Hits          3599    3603    +4     
  Misses        8661    8661           
- Partials       468     473    +5     
Flag Coverage Δ
engine 64.9% <80.6%> (-0.1%) ⬇️
geowidget 19.8% <ø> (ø)
quest 4.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...fhircore/engine/util/extension/PatientExtension.kt 33.3% <ø> (-49.1%) ⬇️
...hircore/engine/util/extension/ResourceExtension.kt 67.8% <90.9%> (+1.9%) ⬆️
...gister/fhircore/engine/rulesengine/RulesFactory.kt 68.4% <55.5%> (-1.9%) ⬇️

pld
pld previously approved these changes Jul 16, 2024
@f-odhiambo f-odhiambo marked this pull request as ready for review July 17, 2024 07:20
- Add tests and fix failing test
@f-odhiambo f-odhiambo added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 5d5454b Jul 17, 2024
5 checks passed
@f-odhiambo f-odhiambo deleted the related-person-age-and-gender branch July 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants