Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

399 | Fixed bug on barcode scanner crash #423

Merged
merged 5 commits into from
Jul 20, 2021
Merged

399 | Fixed bug on barcode scanner crash #423

merged 5 commits into from
Jul 20, 2021

Conversation

maimoonak
Copy link
Contributor

Fixes #399

Type
Bug fix

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test that replicates the error in the issue that fails without this patch and passes with it?

@coveralls
Copy link

coveralls commented Jul 19, 2021

Pull Request Test Coverage Report for Build #209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 32 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 86.264%

Files with Coverage Reduction New Missed Lines %
src/main/java/org/smartregister/fhircore/viewmodel/PatientListViewModel.kt 1 97.37%
src/main/java/org/smartregister/fhircore/fragment/PatientListFragment.kt 31 60.69%
Totals Coverage Status
Change from base Build #205: -0.07%
Covered Lines: 1256
Relevant Lines: 1456

💛 - Coveralls

pld
pld previously approved these changes Jul 20, 2021
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maimoonak maimoonak merged commit 5ebff99 into main Jul 20, 2021
@maimoonak maimoonak deleted the 399_barcode_crash branch July 20, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barcode scanning crashes on search
3 participants