Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos #22

Closed
Oskar-van-Deventer opened this issue Apr 12, 2019 · 4 comments
Closed

Typos #22

Oskar-van-Deventer opened this issue Apr 12, 2019 · 4 comments

Comments

@Oskar-van-Deventer
Copy link
Contributor

Here are some (possible) typos

There is
"publicKey": "ddid:peer:qQk1twjzCmEMgLDRN ..."
I assume the double d in "ddid" is a type

There is a hash "#" in
"publicKey": "ddid:peer:qQk1twjzCmEMgLDRNmo7oS#1"
is that hash a typo, or a feature of DDO?

Why is the DID
"id": "did:peer:qQk1twjzCmEMgLDRNmo7oS"
different from
"for": "did:peer:rjHiqAzCbsNYhMZDTUASHg"
What is the semantics of each DID? Or is this just a typo?
@Oskar-van-Deventer
Copy link
Contributor Author

See #24 for the first typo.

@dhh1128
Copy link
Collaborator

dhh1128 commented May 9, 2019

The PR for the first typo is fixed.
The hash is intentional. It refers to a specific key in the DID doc.
I will check on the third question.

dhh1128 added a commit to dhh1128/peer-did-method-spec-old that referenced this issue May 14, 2019
@dhh1128
Fix GH issue openssi#22 - typo in DID value
c963ee1 
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
dhh1128 added a commit to dhh1128/peer-did-method-spec-old that referenced this issue May 14, 2019
@dhh1128
Fix GH issue openssi#22 - typo in DID value
c176519 
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
dhh1128 added a commit that referenced this issue May 14, 2019
@dhh1128
Merge pull request #27 from dhh1128/master
2af8d40 
Fix GH issue #22 - typo in DID value
@dhh1128
Copy link
Collaborator

dhh1128 commented May 14, 2019

There was indeed a typo related to your third point. This is now fixed and merged (see PR #27 ). @Oskar-van-Deventer , do you agree that we can close the ticket?

@Oskar-van-Deventer
Copy link
Contributor Author

Thank you! Yes, please close.

@dhh1128 dhh1128 closed this as completed May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhh1128 @Oskar-van-Deventer