locatetest doesn't seem to test properly

[paulidale]

Refer:

openssl/test/localetest.c

Lines 94 to 103 in bbe909d

	TEST_ptr(setlocale(LC_ALL, ""));
	res = strcasecmp(str1, str2);
	TEST_note("Case-insensitive comparison via strcasecmp in current locale %s\n", res ? "failed" : "succeeded");
	TEST_false(OPENSSL_strcasecmp(str1, str2));
	cert = d2i_X509(NULL, &p, sizeof(der_bytes));
	if (!TEST_ptr(cert))
	return 0;

Should the TEST_ptr on line 94 and the TEST_false on line 99 both be wrapped by if (...) return 0;?
Without this, the test won't fail but will log output with ERROR in it. IMO, this is not a good thing.

[beldmit]

If we failed on line 94, all other tests don't have much sense and probably we should skip it. You are definitely correct about line 99, if we failed, we should return an error immediately.

[paulidale]

Maybe line 94 should become:

if (setlocale(LC_ALL, "") == NULL)
    return TEST_skip(...);

You could then drop the TEST_note().

[beldmit]

TEST_note has an intention to show if strcasecmp gives an expected result (yes for C, no for Turkish)

[paulidale]

The skip message indicates a bad result. The test continuing indicates a good one. It isn't providing any new information and it clutters the test output (which is already too verbose).

[beldmit]

It's a different information. If strcasecmp works properly, there should be no problems (or crash) in OPENSSL_strcasecmp. Otherwise it's crucial for us that OPENSSL_strcasecmp works properly when strcasecmp` does not.