Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving locale test #18211

Closed
wants to merge 1 commit into from
Closed

Improving locale test #18211

wants to merge 1 commit into from

Conversation

beldmit
Copy link
Member

@beldmit beldmit commented Apr 29, 2022

Fixes #18205

Checklist
  • documentation is added or updated
  • tests are added or updated

@beldmit beldmit added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Apr 29, 2022
@beldmit beldmit requested a review from paulidale April 29, 2022 12:23
@beldmit beldmit added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member and removed approval: otc review pending This pull request needs review by an OTC member labels Apr 29, 2022
@t8m
Copy link
Member

t8m commented Apr 29, 2022

Please add Fixes #18205 to the commit message.

@beldmit
Copy link
Member Author

beldmit commented Apr 29, 2022

Done

@t8m
Copy link
Member

t8m commented Apr 29, 2022

Still approved.

@petrovr
Copy link

petrovr commented Apr 30, 2022 via email

@beldmit
Copy link
Member Author

beldmit commented Apr 30, 2022

For Github CI purposes I added explicit installation of the Turkish langpack. I have no idea how to check if the particular locale is present

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 1, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 2, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request May 2, 2022
@beldmit
Improving locale test
93983e5 
Fixes #18205

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18211)
@beldmit
Copy link
Member Author

beldmit commented May 2, 2022

Merged both to 3.0 and master. Thanks!

@beldmit beldmit closed this May 2, 2022
openssl-machine pushed a commit that referenced this pull request May 2, 2022
@beldmit
Improving locale test
ae3ece0 
Fixes #18205

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18211)

(cherry picked from commit 93983e5)
@beldmit beldmit deleted the fix_18205 branch May 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

locatetest doesn't seem to test properly
5 participants
@beldmit @t8m @petrovr @openssl-machine @paulidale