Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source file crypto/bn/rsa_sup_mul.c does not have a copyright header #20461

Closed
ifranzki opened this issue Mar 8, 2023 · 1 comment
Closed

Source file crypto/bn/rsa_sup_mul.c does not have a copyright header #20461

ifranzki opened this issue Mar 8, 2023 · 1 comment
Labels
branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: bug The issue/pr is/fixes a bug

Comments

@ifranzki
Copy link
Contributor

ifranzki commented Mar 8, 2023

I wonder if the relatively new source file crypto/bn/rsa_sup_mul.c should not also have a copyright header like all the other source files?
@ifranzki ifranzki added the issue: bug report The issue was opened to report a bug label Mar 8, 2023
@mattcaswell mattcaswell added triaged: bug The issue/pr is/fixes a bug and removed issue: bug report The issue was opened to report a bug labels Mar 8, 2023
@mattcaswell
Copy link
Member

Yes, it should.

@t8m t8m added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Mar 8, 2023
paulidale added a commit to paulidale/openssl that referenced this issue Mar 8, 2023
@paulidale
Add missing copyright header
f5135a7 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes openssl#20461
@paulidale paulidale mentioned this issue Mar 8, 2023
Closed
openssl-machine pushed a commit that referenced this issue Mar 14, 2023
@paulidale
Add missing copyright header
cda3c1d 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes #20461

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20470)

(cherry picked from commit 93b0a1e)
openssl-machine pushed a commit that referenced this issue Mar 14, 2023
@paulidale
Add missing copyright header
147098c 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes #20461

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20470)

(cherry picked from commit 93b0a1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing copyright header paulidale/openssl
3 participants
@t8m @mattcaswell @ifranzki