Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing copyright header #20470

Closed
wants to merge 1 commit into from
Closed

Add missing copyright header #20470

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

This file was only recently introduced and the missing header slipped through the review process.

Fixes #20461

@paulidale
Add missing copyright header
f5135a7 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes openssl#20461
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Mar 8, 2023
@paulidale paulidale self-assigned this Mar 8, 2023
@t8m t8m added triaged: bug The issue/pr is/fixes a bug branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch and removed branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Mar 9, 2023
@t8m
Copy link
Member

t8m commented Mar 9, 2023

Do we care about 1.1.1? The copyright header should be different there though.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Mar 9, 2023
@paulidale
Copy link
Contributor Author

We should fix in 1.1.1 & 1.0.2 I guess. Separate PRs for them.

@paulidale paulidale mentioned this pull request Mar 9, 2023
Closed
2 tasks
@paulidale
Copy link
Contributor Author

PRs for 1.1.1 and 1.0.2 created.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 13, 2023
@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Mar 14, 2023
@paulidale paulidale deleted the rsa-sup-mul branch March 14, 2023 21:12
openssl-machine pushed a commit that referenced this pull request Mar 14, 2023
@paulidale
Add missing copyright header
cda3c1d 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes #20461

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20470)

(cherry picked from commit 93b0a1e)
openssl-machine pushed a commit that referenced this pull request Mar 14, 2023
@paulidale
Add missing copyright header
93b0a1e 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes #20461

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20470)
openssl-machine pushed a commit that referenced this pull request Mar 14, 2023
@paulidale
Add missing copyright header
147098c 
This file was only recently introduced and the missing header slipped through
the review process.

Fixes #20461

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20470)

(cherry picked from commit 93b0a1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source file crypto/bn/rsa_sup_mul.c does not have a copyright header
4 participants
@paulidale @t8m @openssl-machine @levitte