Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We're not treating read-only source trees very well #22907

Closed
levitte opened this issue Dec 2, 2023 · 0 comments
Closed

We're not treating read-only source trees very well #22907

levitte opened this issue Dec 2, 2023 · 0 comments
Labels
issue: bug report The issue was opened to report a bug severity: regression The issue/pr is a regression from previous released version

Comments

@levitte
Copy link
Member

levitte commented Dec 2, 2023

See #22841, where this turned out to be the source problem.

It was seen as quite important that the source tree should remain untouched during a normal build, test and install, at least when building out-of-source (separate build tree).
There are environments where this is important, and taken so far that the source tree is to be on a disk that's mounted read-only, or made read-only in some other way (that's the bottom line case in #22841).

This is, unfortunately, untested, and seems to have been forgotten over time, and should be restored in my opinion.

Two things would need to happen:

  • Add a workflow that makes the checkout source tree read-only, and try to build, test, and install from a separate build tree.
  • Fix whatever ends up trying to write in the source tree.
@levitte levitte added issue: bug report The issue was opened to report a bug severity: regression The issue/pr is a regression from previous released version labels Dec 2, 2023
@levitte levitte mentioned this issue Dec 2, 2023
Closed
levitte added a commit to levitte/openssl that referenced this issue Dec 2, 2023
@levitte
Add a workflow to test building from a read-only source tree
a63b1ef 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 2, 2023
@levitte
Configure: Refuse to make directories in the source tree
2d6eafc 
Fixes openssl#22907
@openssl openssl deleted a comment from togtalk Dec 2, 2023
@mspncp mspncp mentioned this issue Dec 2, 2023
Closed
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Add a workflow to test build+test+install from a read-only source tree
d225779 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Configure: Refuse to make directories in the source tree
78e1fe8 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Add a workflow to test build+test+install from a read-only source tree
39141b5 
This includes configuring with the configuration options 'enable-fips',
'enable-quic', 'enable-acvp-tests'.

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Configure: Refuse to make directories in the source tree
efa1065 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
amend! Add a workflow to test build+test+install from a read-only sou…
7cb784c 
…rce tree

Modify 'out-of-source-and-install' to work with a read-only source tree

This also adds the configuration options 'enable-quic'.

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
8ed2555 
This also adds the configuration options 'enable-quic'.

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Configure: Refuse to make directories in the source tree
1427fbe 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
54bed74 
This also adds the configuration options 'enable-quic'.

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 4, 2023
@levitte
Configure: Refuse to make directories in the source tree
33fc79b 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 6, 2023
@levitte
amend! Modify 'out-of-source-and-install' to work with a read-only so…
dd04ea3 
…urce tree

Modify 'out-of-source-and-install' to work with a read-only source tree

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 6, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
834c57c 
This also adds the configuration options 'enable-quic'.

Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 6, 2023
@levitte
Configure: Refuse to make directories in the source tree
0452fed 
Fixes openssl#22907
levitte added a commit to levitte/openssl that referenced this issue Dec 6, 2023
@levitte
amend! Modify 'out-of-source-and-install' to work with a read-only so…
a0db2a4 
…urce tree

Modify 'out-of-source-and-install' to work with a read-only source tree

Fixes openssl#22907
openssl-machine pushed a commit that referenced this issue Dec 7, 2023
@levitte
Configure: Refuse to make directories in the source tree
504ff2a 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #22908)
openssl-machine pushed a commit that referenced this issue Dec 7, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
95a99fd 
This also adds the configuration options 'enable-quic'.

Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #22908)

(cherry picked from commit 266a355)
openssl-machine pushed a commit that referenced this issue Dec 7, 2023
@levitte
Configure: Refuse to make directories in the source tree
96b8bc7 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #22908)

(cherry picked from commit 504ff2a)
openssl-machine pushed a commit that referenced this issue Dec 8, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
d48db01 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)
openssl-machine pushed a commit that referenced this issue Dec 8, 2023
@levitte
Configure: Refuse to make directories in the source tree
487628b 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)
openssl-machine pushed a commit that referenced this issue Dec 8, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
9628a45 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)

(cherry picked from commit d48db01)
openssl-machine pushed a commit that referenced this issue Dec 8, 2023
@levitte
Configure: Refuse to make directories in the source tree
b8e98c3 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)

(cherry picked from commit 487628b)
wbeck10 pushed a commit to wbeck10/openssl that referenced this issue Jan 8, 2024
@levitte @wbeck10p
Modify 'out-of-source-and-install' to work with a read-only source tree
08176ae 
This also adds the configuration options 'enable-quic'.

Fixes openssl#22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#22908)
wbeck10 pushed a commit to wbeck10/openssl that referenced this issue Jan 8, 2024
@levitte @wbeck10p
Configure: Refuse to make directories in the source tree
19b69a3 
Fixes openssl#22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl#22908)
@davecrighton davecrighton mentioned this issue Feb 14, 2024
Closed
@t8m t8m mentioned this issue Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug report The issue was opened to report a bug severity: regression The issue/pr is a regression from previous released version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a workflow to test building from a read-only source tree levitte/openssl
1 participant
@levitte