Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workflow to test building from a read-only source tree [3.1 & 3.0] #22934

Closed
wants to merge 4 commits into from
Closed

Add a workflow to test building from a read-only source tree [3.1 & 3.0] #22934

wants to merge 4 commits into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Dec 4, 2023

... and deal with the consequences.

Note: this is a backport of #22908 for openssl-3.1 and openssl-3.0

@levitte levitte added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: present The PR has suitable tests present labels Dec 4, 2023
@levitte
Copy link
Member Author

levitte commented Dec 4, 2023

I have verified that this cherry-picks cleanly to openssl-3.0

t8m
t8m previously approved these changes Dec 4, 2023
View reviewed changes
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Dec 4, 2023
@slontis
Copy link
Member

slontis commented Dec 5, 2023

Wheres the 'deal with the consequences part' :)

@levitte
Copy link
Member Author

levitte commented Dec 5, 2023

Wheres the 'deal with the consequences part' :)

That's the second commit, which modifies Configure.
I was actually surprised that there was so little to do...

@slontis
Copy link
Member

slontis commented Dec 5, 2023

Is the test failure not related?

@levitte
Copy link
Member Author

levitte commented Dec 6, 2023

PING! #22908 has been approved... any chance this can as well?

@mattcaswell
Copy link
Member

What about the comment from @slontis above?

@levitte
Copy link
Member Author

levitte commented Dec 6, 2023

Whoopsie, of course there should be no enable-quic in this PR...

@levitte levitte requested a review from t8m December 6, 2023 16:29
@levitte levitte dismissed t8m’s stale review December 6, 2023 16:30

Re-review needed

@levitte levitte added the approval: otc review pending This pull request needs review by an OTC member label Dec 6, 2023
@slontis
Copy link
Member

slontis commented Dec 6, 2023

Tests still failing.

@nhorman nhorman self-requested a review December 6, 2023 20:52
@slontis
Copy link
Member

slontis commented Dec 6, 2023

Why is this being approved with test failures?

@levitte
Copy link
Member Author

levitte commented Dec 6, 2023

I think that failure is irrelevant for this PR. I can rebase it, though, and see if fares better

@levitte
Copy link
Member Author

levitte commented Dec 6, 2023 •
edited

I have seen that failure in other PRs, FYI... (#22948, #22929)

@levitte
Copy link
Member Author

levitte commented Dec 6, 2023 •
edited

I have seen that failure in other PRs, FYI... (#22948, #22929)

And that exact same error is in the current openssl-3.1 branch:

https://github.com/openssl/openssl/actions/runs/7117073364/job/19376972990

So, I'll count the approvals as valid.

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Dec 6, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@levitte levitte added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 8, 2023
@levitte
Copy link
Member Author

levitte commented Dec 8, 2023

Merged

3.1:
d48db01 Modify 'out-of-source-and-install' to work with a read-only source tree
487628b Configure: Refuse to make directories in the source tree

3.0:
9628a45 Modify 'out-of-source-and-install' to work with a read-only source tree
b8e98c3 Configure: Refuse to make directories in the source tree

@levitte levitte closed this Dec 8, 2023
openssl-machine pushed a commit that referenced this pull request Dec 8, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
d48db01 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2023
@levitte
Configure: Refuse to make directories in the source tree
487628b 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)
@levitte levitte deleted the workflow-readonly-source-31 branch December 8, 2023 08:00
openssl-machine pushed a commit that referenced this pull request Dec 8, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
9628a45 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)

(cherry picked from commit d48db01)
openssl-machine pushed a commit that referenced this pull request Dec 8, 2023
@levitte
Configure: Refuse to make directories in the source tree
b8e98c3 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #22934)

(cherry picked from commit 487628b)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 15, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
d061b38 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from openssl/openssl#22934)

(cherry picked from commit d48db01f06afbc0557ad04548d07cb16eecaa3e4)
Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 15, 2023
@levitte
Configure: Refuse to make directories in the source tree
97f53f2 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from openssl/openssl#22934)

(cherry picked from commit 487628b62efc5703e44b2f88800e7a340ce17822)
Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 15, 2023
@levitte
Modify 'out-of-source-and-install' to work with a read-only source tree
156b523 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from openssl/openssl#22934)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 15, 2023
@levitte
Configure: Refuse to make directories in the source tree
139fcf2 
Fixes #22907

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from openssl/openssl#22934)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@levitte @slontis @mattcaswell @openssl-machine @nhorman @t8m