-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure build is completed before make test
starts tests
#22943
Comments
If you do just openssl/Configurations/unix-Makefile.tmpl Lines 560 to 563 in 7ebaab7
|
Yep, this must bei the point: parallel |
The real issue here lies in the declared dependency relationships.
The way things stand, from make's pov "build_programs_nodep", "build_modules_nodep", "link-utils" and "run_tests" are declared to be mutually order independent (i.e. potentially parallel jobs). Neither do I believe that make offers any guarantee to resolve target lists left to right, so in theory even make -j1 could fail. |
Recently my 'make test' stopped working.. I am not sure what I have done.. (listing the tests shows nothing also) |
I hope I fixed it. Please have a look at the PRs |
PRs look ok. |
Reopening, 'cause #22948 hasn't been merged yet |
@levitte : can this be closed now? |
Closing as this has been merged to 3.0, 3.1, 3.2, and |
Fixes openssl#22943 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> (Merged from openssl#22947)
Copying @hlandau 's description (with editorial adaptations) from anther issue:
When developing I always find running
make test
after changing a file to result in trying to run some test binariesbefore they are actually finished compiling, resulting in an error, which is why I always run
make && make test
.We should fix that.
The text was updated successfully, but these errors were encountered: