Make sure build is completed before make test starts tests

[DDvO]

Copying @hlandau 's description (with editorial adaptations) from anther issue:

When developing I always find running make test after changing a file to result in trying to run some test binaries
before they are actually finished compiling, resulting in an error, which is why I always run make && make test.
We should fix that.

[levitte]

If you do just make test, I don't see how that could happen. However, if you somehow had -j{n} (explicit or implied somehow), then you're outta luck, because of the parallel dependency where the last one is run-tests:

openssl/Configurations/unix-Makefile.tmpl

Lines 560 to 563 in 7ebaab7

	##@ Testing
	test: tests ## Run tests (alias of "tests")
	{- dependmagic('tests', 'Run tests'); -}: build_programs_nodep build_modules_nodep link-utils run_tests
	run_tests:

[DDvO]

Yep, this must bei the point: parallel make goes wrong then.

[rwfranks]

The real issue here lies in the declared dependency relationships.

##@ Testing
test: tests ## Run tests (alias of "tests")
tests: build_generated ## Run tests
        $(MAKE) depend && $(MAKE) _tests
_tests: build_programs_nodep build_modules_nodep link-utils run_tests
run_tests:

The way things stand, from make's pov "build_programs_nodep", "build_modules_nodep", "link-utils" and "run_tests" are declared to be mutually order independent (i.e. potentially parallel jobs). Neither do I believe that make offers any guarantee to resolve target lists left to right, so in theory even make -j1 could fail.
The build stuff needs to be grouped under a separate target and the tests depend on that target.

[slontis]

Recently my 'make test' stopped working.. I am not sure what I have done.. (listing the tests shows nothing also)
Adding the following manually to the Makefile addresses the issue..
.PHONY: run_tests

[levitte]

I hope I fixed it. Please have a look at the PRs

[rwfranks]

PRs look ok.

[levitte]

Reopening, 'cause #22948 hasn't been merged yet

[jamuir]

@levitte : can this be closed now?

[DDvO]

Closing as this has been merged to 3.0, 3.1, 3.2, and master.