Make sure that the test / tests build target run 'run_tests' last [3.1 & 3.0] #22948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
approval: review pending
levitte
changed the title
For some reason, it was added to the Unix and VMS build templates, but Windows was forgotten.
levitte
force-pushed
the
make-test-sequential-31
branch
from
3c621d5
to
b26e36f
Compare
t8m
approved these changes
Dec 5, 2023
t8m
removed
the
approval: otc review pending
|
PING! #22947 has been approved... any chance this can be as well? |
tmshort
approved these changes
Dec 6, 2023
|
(But not sure it's related?) |
It isn't. |
levitte
added
approval: done
This was referenced Dec 6, 2023
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged 3.1: 3.0: |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 8, 2023
For some reason, it was added to the Unix and VMS build templates, but Windows was forgotten. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from #22948)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 15, 2023
Fixes #22943 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl/openssl#22948) (cherry picked from commit ab2b19e3ccd53932c68d2a2408af83af585c89b0) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 15, 2023
For some reason, it was added to the Unix and VMS build templates, but Windows was forgotten. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl/openssl#22948) (cherry picked from commit a223bfcb89df54093a1858817e02fd6e0cb38219) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 15, 2023
Fixes #22943 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl/openssl#22948) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 15, 2023
For some reason, it was added to the Unix and VMS build templates, but Windows was forgotten. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from openssl/openssl#22948) Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #22947 to openssl-3.1 and openssl-3.0
Fixes #22943