-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: switch issue templates to new labels #10266
Conversation
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #10266)
Merged to cfa71c5 and removed the [feature] and the [bug] label. |
I notice that you removed the "approval: done" label when you added "ready to merge"...is that they way we should do things - or should we keep the "approval: done" after "ready to merge" is additionally added? To me it makes more sense to keep it. |
I wasn’t sure myself whether I should remove it or not. If you prefer to keep it, I‘m ok with it. |
To me the "approval: done" status is not something that is lost simply because we have additionally gained the "ready to merge" status. |
Ok, then I'll restore the label on the recent tickets. (FWIW: bulk adding/removal of labels is possible using multiselection on the issue search page.) |
P.S: The motivation behind removing the 'approval: done' label was to consider 'approval: *' and 'ready for merge' as mutual exclusive ticket states. But viewing them as independent properties makes equally sense. Anyway, I think the @openssl/omc needs to state a clear policy for handling the 'approval: *' and 'ready to merge' labels, in particular in the case when the 'approval: ready' state needs to be withdrawn (e.g. because there was a force push after 'ready to merge'). Partial support by a GitHub bot might be helpful, but not sufficient for all use cases. |
(To be sure about the syntax, I created a test template using the wizard.)