mac: deprecate low level calls to CMAC and HMAC. #10836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CMAC is complete. HMAC is more problematic. |
levitte
requested changes
Jan 14, 2020
levitte
reviewed
Jan 14, 2020
paulidale
changed the title
|
Bringing this out of WiP for review. The Travis failure isn't relevant. |
mattcaswell
requested changes
Jan 24, 2020
| * Test 10: TLSv1.2, ticket key callback, ticket, renewal | ||
| * Test 11: TLSv1.3, ticket key callback, ticket, renewal | ||
| */ | ||
| static int test_ticket_callbacks(int tst) |
There was a problem hiding this comment.
Surely test_ticket_callbacks and test_old_ticket_callbacks can be combined in some way. Virtually of the code is identical. Tests 0-7 are identical aren't they (no ticket key callback)? Probably we should have just one function with tests 12-15 added which use the new callback instead.
There was a problem hiding this comment.
I thought about this but got worried about the #ifdefs. I'll revisit the idea.
There was a problem hiding this comment.
This ended up pretty clean.
|
I think that's all the comments addressed. |
mattcaswell
requested changes
Jan 24, 2020
paulidale
force-pushed
the
mac
branch
2 times, most recently
from
b55e515
to
37af71e
Compare
|
Ping? |
levitte
reviewed
Jan 27, 2020
This does look good enough to me, but I would like to see @mattcaswell pitch in one last time as well before approval. |
Use of the low level CMAC functions has been informally discouraged for a long time. We now formally deprecate them. Applications should instead use EVP_MAC_CTX_new(3), EVP_MAC_CTX_free(3), EVP_MAC_init(3), EVP_MAC_update(3) and EVP_MAC_final(3).
Use of the low level HMAC functions has been informally discouraged for a long time. We now formally deprecate them. Applications should instead use EVP_MAC_CTX_new(3), EVP_MAC_CTX_free(3), EVP_MAC_init(3), EVP_MAC_update(3) and EVP_MAC_final(3).
Backwards compatibility with the old ticket key call back is maintained. This will be removed when the low level HMAC APIs are finally removed.
mattcaswell
added
the
approval: done
paulidale
added
approval: ready to merge
|
Merged to master. Thanks for the positive input. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 29, 2020
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10836)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 29, 2020
Use of the low level CMAC functions has been informally discouraged for a long time. We now formally deprecate them. Applications should instead use EVP_MAC_CTX_new(3), EVP_MAC_CTX_free(3), EVP_MAC_init(3), EVP_MAC_update(3) and EVP_MAC_final(3). Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10836)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 29, 2020
Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10836)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 29, 2020
Use of the low level HMAC functions has been informally discouraged for a long time. We now formally deprecate them. Applications should instead use EVP_MAC_CTX_new(3), EVP_MAC_CTX_free(3), EVP_MAC_init(3), EVP_MAC_update(3) and EVP_MAC_final(3). Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10836)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 29, 2020
Backwards compatibility with the old ticket key call back is maintained. This will be removed when the low level HMAC APIs are finally removed. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #10836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the low level CMAC and HMAC functions has been informally discouraged for a long time. We now formally deprecate them.