Implement Serializers for Ed25519 and Ed448 #11272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a fairly simple change in the last 2 commits. (tests need some fixing - but it looks almost there) |
This is largely based on the existing X25519 and X448 serializers - but a few adjustments were necessary so that we can identify what type of key we are using. Previously we used the keylen for this but X25519 and ED25519 have the same keylen.
We build on the existing X25519 and X448 serializer tests.
mattcaswell
changed the title
mattcaswell
force-pushed
the
eddsa-serializer
branch
from
53d62ee
to
ed413e8
Compare
|
Now that #11261 has gone in I've rebased this, and fixed the travis issues. This is now ready to review - please take a look. |
|
1 travis error left - probably related to no-ec |
|
Fixup pushed to address the travis failure. |
slontis
approved these changes
Mar 11, 2020
slontis
added
the
approval: ready to merge
|
A quick push of this after the defrosting of the repo would be nice. |
|
will try merging this again now.. |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 17, 2020
This is largely based on the existing X25519 and X448 serializers - but a few adjustments were necessary so that we can identify what type of key we are using. Previously we used the keylen for this but X25519 and ED25519 have the same keylen. Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #11272)
|
Merged to master. |
|
Thanks for merging this @slontis |
kaduk
reviewed
Apr 21, 2020
| #define KEYNID2TYPE(id) \ | ||
| (IS25519(id) ? ECX_KEY_TYPE_X25519 \ | ||
| : ((id) == EVP_PKEY_X448 ? ECX_KEY_TYPE_X448 \ | ||
| : ((id) == EVP_PKEY_ED25519 ? ECX_KEY_TYPE_ED25519 \ |
There was a problem hiding this comment.
Isn't the first IS25519 going to catch both x25519 and ed25519? I'm not sure how this last EVP_PKEY_ED25519 check is going to do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the serializers and associated tests for the Ed25519 and Ed448 algorithms. The docs were already done when the X25519/X448 serializers were added since the interface is the same.
This is WIP because it depends on and includes the commits from #11261. Aside from that it is complete.