Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups in CHANGES.md #11447

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

levitte
Copy link
Member

@levitte levitte commented Mar 31, 2020

Fixed one ambiguous line and removed a few unnecessary backticks.

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Mar 31, 2020
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 31, 2020
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m
Copy link
Member

t8m commented Apr 1, 2020

The Travis passed here just the reporting back to github is somehow stuck.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 1, 2020
Fixed one ambiguous line and removed a few unnecessary backticks.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#11447)
@openssl-machine openssl-machine merged commit ccb8f0c into openssl:master Apr 1, 2020
@levitte levitte deleted the fix-CHANGES-20200331 branch April 1, 2020 19:31
levitte added a commit to levitte/openssl that referenced this pull request Apr 3, 2020
Fixed one ambiguous line and removed a few unnecessary backticks.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from openssl#11447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants