Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few more tests to use the new fipsinstall script #11580

Closed
wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

Commit ae6b654 introduced a new script to make running fipsinstall
easier. A few tests were added around the same time as that commit that
still do it the old way - so we fix those up.

Checklist
  • documentation is added or updated
  • tests are added or updated

Commit ae6b654 introduced a new script to make running fipsinstall
easier. A few tests were added around the same time as that commit that
still do it the old way - so we fix those up.
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Apr 20, 2020
This was referenced Apr 20, 2020
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulidale
Copy link
Contributor

Assuming CIs agree

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 20, 2020
@slontis
Copy link
Member

slontis commented Apr 21, 2020

Maybe this should be titled - 'break a few more tests on mac' :).

Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont merge this until existing problems are fixed on MAC.

@mattcaswell
Copy link
Member Author

Closing due to #11592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants