Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix two invalid <B> tags #11759

Closed
wants to merge 1 commit into from
Closed

Conversation

bbolli
Copy link
Contributor

@bbolli bbolli commented May 7, 2020

Signed-off-by: Beat Bolli dev@drbeat.li

I stumbled upon the first one by chance, then checked if there were any others.

Checklist
  • documentation is added or updated

Signed-off-by: Beat Bolli <dev@drbeat.li>
@levitte levitte added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels May 7, 2020
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 7, 2020
@richsalz
Copy link
Contributor

richsalz commented May 7, 2020

Hey, @bbolli nice to see you again :)

@bbolli
Copy link
Contributor Author

bbolli commented May 7, 2020

Hey, @richsalz Or, as my Twitter handle says: "Occasional OSS contributor"...

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@kaduk kaduk added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 8, 2020
@kaduk
Copy link
Contributor

kaduk commented May 8, 2020

Setting ready-to-merge since the comments after 'approval:done' was set were just socializing.
Did anyone have plans to merge?

@kaduk
Copy link
Contributor

kaduk commented May 10, 2020

Hearing nothing, I will go ahead and merge.

openssl-machine pushed a commit that referenced this pull request May 10, 2020
Signed-off-by: Beat Bolli <dev@drbeat.li>

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #11759)
@kaduk
Copy link
Contributor

kaduk commented May 10, 2020

Merged to master, so closing.
Thanks for the fix!

@kaduk kaduk closed this May 10, 2020
@bbolli bbolli deleted the doc-b-tags branch May 11, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants