Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some doc nits #11902

Closed
wants to merge 3 commits into from
Closed

Clean up some doc nits #11902

wants to merge 3 commits into from

Conversation

richsalz
Copy link
Contributor

Mostly "No items in =over/=back list"

Didn't anyone notice this when they did "make doc-nits" ? :)

Mostly "No items in =over/=back list"
@mspncp
Copy link
Contributor

mspncp commented May 21, 2020

Didn't anyone notice this when they did "make doc-nits" ? :)

Hmmm... 'make doc-nits' does not report anything to me on current master (e1c6f76)?

~/src/openssl$ git log --oneline -1 
e1c6f76281 (HEAD -> master, origin/master, origin/HEAD, github/master, github/gh-2067) There is no -signreq option in CA.pl

~/src/openssl$ make doc-nits
/usr/bin/perl ./util/find-doc-nits -n -l -e

@mspncp
Copy link
Contributor

mspncp commented May 21, 2020

I like your topic branch name.

@richsalz
Copy link
Contributor Author

Must have different versions of some perl utils. On my mac, I get:

MAC ~/git/openssl$ mk doc-nits
/usr/bin/perl ./util/find-doc-nits -n -l -e
*** WARNING: No items in =over (at line 22) / =back list at line 27 in file doc/man3/X509_get0_distinguishing_id.pod
*** WARNING: No items in =over (at line 12) / =back list at line 52 in file doc/man7/EVP_MD-common.pod
*** WARNING: No items in =over (at line 19) / =back list at line 25 in file doc/man7/OSSL_PROVIDER-FIPS.pod
*** WARNING: No items in =over (at line 18) / =back list at line 22 in file doc/man7/OSSL_PROVIDER-default.pod
*** WARNING: No items in =over (at line 21) / =back list at line 25 in file doc/man7/OSSL_PROVIDER-legacy.pod

MAC ~/git/openssl$ 

On linux I get:

; ./util/find-doc-nits -n -l -e
Trying to read doc/man3/ISSUER_SIGN_TOOL_new.pod: No such file or directory
        exit 2
; 

Not sure what's going on with the latter but the former is the subject of this PR.

@mspncp
Copy link
Contributor

mspncp commented May 21, 2020

Regarding the latter: try to reconfigure and run doc-nits again. The file ISSUER_SIGN_TOOL_new.pod was removed in d9321c0.

@slontis
Copy link
Member

slontis commented May 21, 2020

I am seeing these also.. not sure why others are not.

@slontis slontis added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels May 21, 2020
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Running doc-nits for me on the current master also shows no problems. Strange.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 22, 2020
@levitte
Copy link
Member

levitte commented May 22, 2020

Some of this has a better clean-up in #11610...

@richsalz
Copy link
Contributor Author

The error "no items in =over" comes from Pod::Checker.pm, which is 5.18 on my mac and does not show up in my Linux box which is 5.26

@levitte
Copy link
Member

levitte commented May 22, 2020

According to the current Pod::Checker documentation, there is now a empty =over/=back block... I suspect someone pointed out that =over/=back is useful for indented paragraphs in general, not just item lists.

@richsalz
Copy link
Contributor Author

Perhaps it can be useful, but the examples in the source, so far, don't seem that. Using "code" formatting addresses most of them, and fixing the other item gets the last one. It's about catching the common (error) case.

But yes, this is a matter of opinion, and if the project things I'm wrong, close this.

@levitte
Copy link
Member

levitte commented May 22, 2020

But yes, this is a matter of opinion, and if the project things I'm wrong, close this.

Er, what I just said was related to the development of perl and its modules, not to OpenSSL

doc/man7/EVP_MD-common.pod Outdated Show resolved Hide resolved
doc/man7/OSSL_PROVIDER-FIPS.pod Outdated Show resolved Hide resolved
doc/man7/OSSL_PROVIDER-default.pod Outdated Show resolved Hide resolved
doc/man7/OSSL_PROVIDER-legacy.pod Outdated Show resolved Hide resolved
@richsalz
Copy link
Contributor Author

Fixup commit pushed, and another commit to undo the man7 over/back nits.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@richsalz
Copy link
Contributor Author

This can be merged now.

openssl-machine pushed a commit that referenced this pull request May 26, 2020
Mostly "No items in =over/=back list"

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #11902)
@mspncp
Copy link
Contributor

mspncp commented May 26, 2020

Merged to master as e847085, thanks!

@richsalz richsalz closed this May 26, 2020
@richsalz richsalz deleted the doc-nits-sigh branch May 26, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants