-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some doc nits #11902
Clean up some doc nits #11902
Conversation
Mostly "No items in =over/=back list"
Hmmm... 'make doc-nits' does not report anything to me on current master (e1c6f76)?
|
I like your topic branch name. |
Must have different versions of some perl utils. On my mac, I get:
On linux I get:
Not sure what's going on with the latter but the former is the subject of this PR. |
Regarding the latter: try to reconfigure and run doc-nits again. The file ISSUER_SIGN_TOOL_new.pod was removed in d9321c0. |
I am seeing these also.. not sure why others are not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Running doc-nits for me on the current master also shows no problems. Strange.
Some of this has a better clean-up in #11610... |
The error "no items in =over" comes from Pod::Checker.pm, which is 5.18 on my mac and does not show up in my Linux box which is 5.26 |
According to the current Pod::Checker documentation, there is now a empty =over/=back block... I suspect someone pointed out that =over/=back is useful for indented paragraphs in general, not just item lists. |
Perhaps it can be useful, but the examples in the source, so far, don't seem that. Using "code" formatting addresses most of them, and fixing the other item gets the last one. It's about catching the common (error) case. But yes, this is a matter of opinion, and if the project things I'm wrong, close this. |
Er, what I just said was related to the development of perl and its modules, not to OpenSSL |
Fixup commit pushed, and another commit to undo the man7 over/back nits. |
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
This can be merged now. |
Mostly "No items in =over/=back list" Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #11902)
Merged to master as e847085, thanks! |
Mostly "No items in =over/=back list"
Didn't anyone notice this when they did "make doc-nits" ? :)