Remove util/openssl-update-copyright #12466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was useful at the time for a one-time run. However, since it does its work based on file modification time stamps, and those are notoriously untrustable in a git checkout, it ends up being harmful. There is a replacement in OpenSSL's tools repository, which relies on git history. Fixes openssl#12462
levitte
added
branch: master
|
Note that this should happen in 1.1.1 as well. |
t8m
approved these changes
Jul 16, 2020
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged 1bb78e7 Remove util/openssl-update-copyright |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 19, 2020
It was useful at the time for a one-time run. However, since it does its work based on file modification time stamps, and those are notoriously untrustable in a git checkout, it ends up being harmful. There is a replacement in OpenSSL's tools repository, which relies on git history. Fixes #12462 Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #12466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was useful at the time for a one-time run. However, since it does
its work based on file modification time stamps, and those are
notoriously untrustable in a git checkout, it ends up being harmful.
There is a replacement in OpenSSL's tools repository, which relies on
git history.
Fixes #12462