Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DSA harder. #13187

Closed
wants to merge 11 commits into from
Closed

Deprecate DSA harder. #13187

wants to merge 11 commits into from

Conversation

paulidale
Copy link
Contributor

This deprecates all functions that deal with the types DSA and DSA_SIG.

  • documentation is added or updated
  • tests are added or updated

levitte and others added 4 commits October 17, 2020 14:20
@levitte
Deprecate RSA harder
43636ff 
This deprecates all functions that deal with the types RSA and RSA_METHOD
@levitte
fixup! Deprecate RSA harder
5246a5c
@mspncp @paulidale
README: make the link to the OpenSSL 3.0 Wiki page more prominent
5e85839 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#13164)
@mspncp @paulidale
Change markdown link style in README, INSTALL, SUPPORT and CONTRIBUTING
a6f7bf9 
Replace [collapsed reference links][] by [shortcut reference links],
in order to to improve the readability of the raw markdown text,
see also commit d8dc853 (Change CVE link style in CHANGES and NEWS).

[collapsed reference links]:
  https://github.github.com/gfm/#collapsed-reference-link

[shortcut reference links]:
  https://github.github.com/gfm/#shortcut-reference-link

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#13165)
@paulidale paulidale added the branch: master Merge to master branch label Oct 20, 2020
@paulidale paulidale added this to the 3.0.0 beta1 milestone Oct 20, 2020
@paulidale paulidale self-assigned this Oct 20, 2020
@paulidale paulidale added this to In progress in 3.0 New Core + FIPS via automation Oct 20, 2020
levitte
levitte reviewed Oct 20, 2020
View reviewed changes
include/openssl/pem.h Outdated Show resolved Hide resolved
@levitte
Copy link
Member

levitte commented Oct 20, 2020

Why does this depend on #13096?

@paulidale
Copy link
Contributor Author

paulidale commented Oct 20, 2020 •
edited

The main one is that OSSL_ENCODER_CTX_new_by_EVP_PKEY() has changed. It's a dependency on #13167 really.

There are some other documentation changes that happen in #13096 which this depends on d2i_RSAPrivateKey.pod e.g.

@levitte
Copy link
Member

levitte commented Oct 20, 2020

There are some other documentation changes that happen in #13096 which this depends on d2i_RSAPrivateKey.pod e.g.

Ah! Yeahok, makes sense

@romen romen added the triaged: OTC evaluated This issue/pr was triaged by OTC label Nov 10, 2020
@kroeckx
Copy link
Member

kroeckx commented Nov 24, 2020

This fixes #13121?

@levitte
Copy link
Member

levitte commented Nov 25, 2020

#13096 is merged, so this should be rebased

@paulidale paulidale changed the title [WIP, Pending on #13096] Deprecate DSA harder. Deprecate DSA harder. Nov 25, 2020
@paulnelsontx paulnelsontx added this to review pending in 3.0.0 estimator Dec 1, 2020
@paulnelsontx paulnelsontx moved this from review pending to In progress in 3.0.0 estimator Dec 1, 2020
@paulnelsontx paulnelsontx moved this from In progress to Triaged in 3.0.0 estimator Dec 1, 2020
@levitte
Copy link
Member

levitte commented Dec 4, 2020

Please rebase this

@levitte
Copy link
Member

levitte commented Dec 8, 2020

Upon request, I've taken it upon me to finish this PR. It will appear as another PR, at which point this one will be closed.

@levitte levitte mentioned this pull request Dec 8, 2020
Closed
@levitte
Copy link
Member

levitte commented Dec 8, 2020

Closed in favor of #13638

@levitte levitte closed this Dec 8, 2020
3.0 New Core + FIPS automation moved this from In progress to Done Dec 8, 2020
3.0.0 estimator automation moved this from Triaged to Done Dec 8, 2020
@paulidale paulidale deleted the dsa branch June 9, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte left review comments

Assignees

@paulidale paulidale

Labels
branch: master Merge to master branch triaged: OTC evaluated This issue/pr was triaged by OTC
Projects
No open projects
3.0 New Core + FIPS
  
Done
3.0.0 estimator
Done
Milestone
3.0.0 beta1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulidale @levitte @kroeckx @romen @mspncp