Fix use of verification callback for strict checks and document newly added checks #13312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
reviewed
Nov 4, 2020
in particular regarding the checks due to X509_V_FLAG_X509_STRICT/-x509_strict
…in check_chain() Fixes openssl#13283
DDvO
force-pushed
the
fix_13283_strict_check_callback
branch
from
729b106
to
1e1a2f2
Compare
t8m
reviewed
Nov 4, 2020
…erification cb function
|
@t8m, is there anything further to improve on this PR? |
t8m
added
approval: done
DDvO
added
the
approval: ready to merge
|
Merged - thanks @t8m |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 6, 2020
in particular regarding the checks due to X509_V_FLAG_X509_STRICT/-x509_strict Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13312)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 6, 2020
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13312)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 6, 2020
…tion cb function Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #13312)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x509_vfy.c: Call verification callback individually per strict check incheck_chain().To this end, introduce
CHECK_CBmacro simplifying use of cert verification callback functionCHANGES.md: Mention (strict) checks recently added to X509_verify_cert()X509_verify_cert(), also inopenssl.pod,in particular regarding the checks due to X509_V_FLAG_X509_STRICT/-x509_strict
Fixes #13283