Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-tests on mingw #14249

Closed
wants to merge 1 commit into from
Closed

Fix no-tests on mingw #14249

wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

Using the no-tests option on mingw in an out-of-source build tree was
failing.

Fixes #14246

@mattcaswell
Fix no-tests on mingw
bdf4319 
Using the no-tests option on mingw in an out-of-source build tree was
failing.

Fixes openssl#14246
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Feb 19, 2021
@mattcaswell mattcaswell mentioned this pull request Feb 19, 2021
Closed
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 19, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 20, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 22, 2021
@mattcaswell
Fix no-tests on mingw
f16f363 
Using the no-tests option on mingw in an out-of-source build tree was
failing.

Fixes #14246

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14249)
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpha12 with mingw "cp: cannot create regular file 'test/': Not a directory"
3 participants
@mattcaswell @openssl-machine @t8m