Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make update #14292

Closed
wants to merge 1 commit into from
Closed

make update #14292

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Feb 23, 2021

No description provided.

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Feb 23, 2021
@levitte levitte self-assigned this Feb 23, 2021
@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Feb 23, 2021
openssl-machine pushed a commit that referenced this pull request Feb 23, 2021
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #14292)
@paulidale
Copy link
Contributor

Merged to master.

Do we need an issue raised to fix the make update checker?

@rsbeckerca
Copy link
Contributor

I don't think this will have an impact on the NonStop builds, but I'm checking anyway.

@levitte
Copy link
Member Author

levitte commented Feb 23, 2021

Do we need an issue raised to fix the make update checker?

Why? It already does its job properly, the only issue is when we have several merges going in at a quick pace, then we occasionally miss something. I don't see that as a biggie.

@paulidale
Copy link
Contributor

@levitte thanks for the response. I suspected as much but figured it was better to ask than not.

@paulidale paulidale closed this Feb 23, 2021
@levitte levitte deleted the make-update-20210223 branch February 24, 2021 03:36
@levitte
Copy link
Member Author

levitte commented Feb 24, 2021

Thanks for merging it so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants