Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Only update doc/build.info when there's an actual change #14309

Closed
wants to merge 1 commit into from
Closed

Makefile: Only update doc/build.info when there's an actual change #14309

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Feb 24, 2021

Fixes #14307

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Feb 24, 2021
@levitte levitte mentioned this pull request Feb 24, 2021
Closed
paulidale
paulidale approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for confirmation that it fixes the problem.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 24, 2021
@richsalz
Copy link
Contributor

Yes, this fixes the problem I reported.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@levitte
Copy link
Member Author

levitte commented Feb 26, 2021

Merged

5a6a6d5 Makefile: Only update doc/build.info when there's an actual change

@levitte levitte closed this Feb 26, 2021
@levitte levitte deleted the fix-14307 branch February 26, 2021 07:55
openssl-machine pushed a commit that referenced this pull request Feb 26, 2021
@levitte
Makefile: Only update doc/build.info when there's an actual change
5a6a6d5 
Fixes #14307

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #14309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build process broke/changed
5 participants
@levitte @richsalz @openssl-machine @t8m @paulidale