Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test minimal windows build using Github actions #14737

Closed
wants to merge 6 commits into from
Closed

Test minimal windows build using Github actions #14737

wants to merge 6 commits into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Mar 30, 2021

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis added the branch: master Merge to master branch label Mar 30, 2021
@slontis slontis force-pushed the github_action_windoze branch 4 times, most recently from aded8d9 to 1e73259 Compare March 30, 2021 04:34
@levitte
Copy link
Member

levitte commented Mar 30, 2021

Might í suggest splitting up the tasks in several steps instead of one single run?

@slontis
Copy link
Member Author

slontis commented Mar 30, 2021

Might í suggest splitting up the tasks in several steps instead of one single run?

I was doing this because the ilammy/msvc-dev-cmd@v1 does the MSDEV command line prompt.. I wasnt sure how persistent things were..

@slontis slontis force-pushed the github_action_windoze branch 2 times, most recently from 1d70e05 to fc2284c Compare March 30, 2021 05:12
@slontis
Copy link
Member Author

slontis commented Mar 30, 2021

Woohoo - minimal windows build and test in 13 minutes..

@slontis
Copy link
Member Author

slontis commented Mar 30, 2021

This is quite readable now.

@levitte levitte added the approval: done This pull request has the required number of approvals label Mar 30, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Mar 31, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Mar 31, 2021
openssl-machine pushed a commit that referenced this pull request Mar 31, 2021
@slontis
Test miminal windows build using Github actions
6ec37db 
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #14737)
@slontis
Copy link
Member Author

slontis commented Mar 31, 2021

Thanks for the improvements @levitte. Merged to master.

@slontis slontis closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slontis @levitte @openssl-machine