Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github workflows: re-implement a no-shared build #14753

Closed
wants to merge 1 commit into from
Closed

Github workflows: re-implement a no-shared build #14753

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Mar 31, 2021

We do this both on Ubuntu and MacOS X

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Mar 31, 2021
@t8m
Copy link
Member

t8m commented Mar 31, 2021

And now you have to solve the duplicate symbols problem.

@levitte
Copy link
Member Author

levitte commented Mar 31, 2021

So I guess it's time to resurrect #11311

@levitte levitte mentioned this pull request Mar 31, 2021
Closed
@levitte
Copy link
Member Author

levitte commented Mar 31, 2021

Re-created in #14755

@levitte
Copy link
Member Author

levitte commented Mar 31, 2021

For testing purposes, I've a merge of this and #14755 in https://github.com/levitte/openssl/tree/fix-11281%2B%2Bworkflow-reimplement-no-shared

@levitte levitte mentioned this pull request Mar 31, 2021
Closed
slontis
slontis approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go when the dependancy is fixed..
Try not to add too many more macos builds if we can help it..

@levitte
Github workflows: re-implement a no-shared build
5c79efe 
We do this both on Ubuntu and MacOS X
@levitte levitte force-pushed the workflow-reimplement-no-shared branch from 7f4deec to 5c79efe Compare April 7, 2021 20:12
@levitte
Copy link
Member Author

levitte commented Apr 7, 2021

Rebased just to prove that it now builds without failure

slontis
slontis approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved.

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 8, 2021
@h-vetinari h-vetinari mentioned this pull request Apr 8, 2021
Closed
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 9, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Apr 15, 2021
@levitte
Github workflows: re-implement a no-shared build
4a95b70 
We do this both on Ubuntu and MacOS X

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #14753)
@levitte
Copy link
Member Author

levitte commented Apr 15, 2021

Merged

4a95b70 Github workflows: re-implement a no-shared build

@levitte levitte closed this Apr 15, 2021
@levitte levitte deleted the workflow-reimplement-no-shared branch April 15, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@levitte @t8m @openssl-machine @slontis