Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SipHash: Fix CTRL API for the digest size. #14850

Closed
wants to merge 2 commits into from
Closed

SipHash: Fix CTRL API for the digest size. #14850

wants to merge 2 commits into from

Conversation

paulidale
Copy link
Contributor

Adds a mapping from "digestsize" to "size" for setting a param.

Fixes #14370

  • documentation is added or updated
  • tests are added or updated

@paulidale
SipHash: Fix CTRL API for the digest size.
cd43553 
Adds a mapping from "digestsize" to "size" for setting a param.

Fixes openssl#14370
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Apr 13, 2021
@paulidale paulidale self-assigned this Apr 13, 2021
@mattcaswell mattcaswell added this to the 3.0.0 beta1 milestone Apr 14, 2021
@paulidale
Copy link
Contributor Author

Ping for review?

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 14, 2021
openssl-machine pushed a commit that referenced this pull request Apr 15, 2021
@paulidale
SipHash: Fix CTRL API for the digest size.
34ed733 
Adds a mapping from "digestsize" to "size" for setting a param.

Fixes #14370

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #14850)
@paulidale
Copy link
Contributor Author

Merged to master, thanks for the reviews.

@paulidale paulidale closed this Apr 15, 2021
@paulidale paulidale deleted the siphash branch June 9, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@slontis slontis slontis approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
3.0.0 beta1
Development

Successfully merging this pull request may close these issues.

SipHash via EVP_PKEY has lost support for EVP_PKEY_CTRL_SET_DIGEST_SIZE
4 participants
@paulidale @levitte @slontis @mattcaswell