Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity 7 june #15635

Closed
wants to merge 11 commits into from
Closed

Coverity 7 june #15635

wants to merge 11 commits into from

Conversation

paulidale
Copy link
Contributor

@paulidale paulidale commented Jun 7, 2021 •
edited
Loading

Fix Coverity issues 1485659 through 1485670.

Most of these look to be ignored defects that have reappeared due to the recent function renaming in #15405.
Fixing them in the code rather than ignoring them so they never reappear.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Jun 7, 2021
@paulidale paulidale added this to the 3.0.0 beta1 milestone Jun 7, 2021
@paulidale paulidale self-assigned this Jun 7, 2021
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jun 7, 2021
@paulidale paulidale force-pushed the coverity-7-june branch 2 times, most recently from 1708621 to 3268b58 Compare June 7, 2021 00:35
@paulidale paulidale removed the approval: review pending This pull request needs review by a committer label Jun 7, 2021
slontis
slontis reviewed Jun 7, 2021
View reviewed changes
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e_ *.c files all legacy functions now - do we really care?

@paulidale
Copy link
Contributor Author

Coverity being happy is a release criteria, apart from that the care is low :)

t8m
t8m requested changes Jun 7, 2021
View reviewed changes
crypto/evp/ctrl_params_translate.c Outdated Show resolved Hide resolved
crypto/evp/evp_enc.c Outdated Show resolved Hide resolved
@t8m t8m added the approval: done This pull request has the required number of approvals label Jun 7, 2021
@paulidale
Copy link
Contributor Author

Merged to master, thanks for the comments.

@paulidale paulidale closed this Jun 8, 2021
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
bio: improve error checking fixing coverity 1485659 & 1485665
37bbe44 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
fix coverity 1485660 improper use of negative value
6c1d17c 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
afalg: fix coverity 1485661 improper use of negative value
b0a0ab0 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: fix improper use of negative value issues
042f8f7 
Coverity issues 1485662, 1485663 & 1485664.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: fix coverity 1485666 argument cannot be negative
0341ff9 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
pkcs12: fix Coverity 1485667 logically dead code
9428977 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: fix Coverity 1485668 argument cannot be negative
dacb0d8 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: fix Coverity 1485669 improper use of negative value
3f61706 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: fix Coverity 1485670 argument cannot be negative
cec8854 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
openssl-machine pushed a commit that referenced this pull request Jun 8, 2021
@paulidale
evp: avoid some calls to EVP_CIPHER_CTX_get_iv_length() because it's …
69807ab 
…been called already

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #15635)
@paulidale paulidale deleted the coverity-7-june branch June 8, 2021 09:34
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
bio: improve error checking fixing coverity 1485659 & 1485665
073b8b1 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
fix coverity 1485660 improper use of negative value
ec85657 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
afalg: fix coverity 1485661 improper use of negative value
33a7fd1 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: fix improper use of negative value issues
afb9923 
Coverity issues 1485662, 1485663 & 1485664.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: fix coverity 1485666 argument cannot be negative
d119072 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
pkcs12: fix Coverity 1485667 logically dead code
6daacdb 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: fix Coverity 1485668 argument cannot be negative
8cad84d 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: fix Coverity 1485669 improper use of negative value
392529f 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: fix Coverity 1485670 argument cannot be negative
b9e2d41 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
@paulidale @devnexen
evp: avoid some calls to EVP_CIPHER_CTX_get_iv_length() because it's …
ca01d74 
…been called already

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#15635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slontis slontis slontis left review comments

@t8m t8m t8m approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources
Projects
None yet
Milestone
3.0.0 beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@paulidale @t8m @slontis