fips module header inclusion fine-tunning #15974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
severity: fips change
mattcaswell
added
approval: done
t8m
removed
the
approval: done
|
Approval is a little bit premature. It will need more fine-tunnings to satisfy all the various CI configurations. |
github-actions
bot
added
the
severity: fips change
|
@mattcaswell please re-approve. It seems just this simple fixup was needed. |
t8m
added
the
approval: review pending
paulidale
approved these changes
Jul 1, 2021
paulidale
added
approval: done
levitte
approved these changes
Jul 2, 2021
|
A few more tweaks. Please re-approve. Unfortunately getting rid of include/openssl/asn1* and include/openssl/bio* seems too hard and invasive. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t-j-h
approved these changes
Jul 3, 2021
levitte
approved these changes
Jul 3, 2021
paulidale
approved these changes
Jul 3, 2021
mattcaswell
added
approval: ready to merge
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 6, 2021
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #15974)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 6, 2021
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #15974)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15974)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a few nasty include files being part of the fips module sources.